Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix memory query on unrelated node label changes #105

Merged
merged 5 commits into from Dec 21, 2022
Merged

Fix memory query on unrelated node label changes #105

merged 5 commits into from Dec 21, 2022

Conversation

bastjan
Copy link
Contributor

@bastjan bastjan commented Dec 2, 2022 •
edited

Summary

  • Fixes appuio_cloud_memory query to work both on related and unrelated kube_node_labels changes
  • Adds a bunch of tests and restructures the appuio_cloud_memory testing to make additional test cases easier.
  • Checks jsonnet formatting in CI and allows make fmt to also format jsonnet.

Checklist

  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog
  • Update tests.

@bastjan bastjan mentioned this pull request Dec 2, 2022
Closed
@bastjan bastjan force-pushed the fix-mem-query-on-label-change branch from 8426505 to e3483c9 Compare December 20, 2022 15:08
@bastjan bastjan changed the base branch from master to test-promql December 20, 2022 15:08
Base automatically changed from test-promql to master December 20, 2022 15:29
@bastjan bastjan force-pushed the fix-mem-query-on-label-change branch from 3243ad4 to a0c9bce Compare December 21, 2022 09:29
@bastjan bastjan changed the title PoC: Fix memory query on unrelated node label change Fix memory query on unrelated node label change Dec 21, 2022
@bastjan bastjan force-pushed the fix-mem-query-on-label-change branch from a0c9bce to e3d205e Compare December 21, 2022 09:34
@bastjan bastjan force-pushed the fix-mem-query-on-label-change branch from e3d205e to 5de33ab Compare December 21, 2022 10:00
@bastjan bastjan marked this pull request as ready for review December 21, 2022 10:08
@bastjan bastjan force-pushed the fix-mem-query-on-label-change branch from 08e1800 to 43d48a7 Compare December 21, 2022 11:01
@bastjan bastjan requested a review from simu December 21, 2022 11:05
@bastjan bastjan changed the title Fix memory query on unrelated node label change Fix memory query on unrelated node label changes Dec 21, 2022
@bastjan bastjan added the bug Something isn't working label Dec 21, 2022
simu
simu approved these changes Dec 21, 2022
View reviewed changes
Copy link
Member

@simu simu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Very nice test abstraction 👍

@bastjan bastjan merged commit b5960e3 into master Dec 21, 2022
@bastjan bastjan deleted the fix-mem-query-on-label-change branch December 21, 2022 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simu simu simu approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bastjan @simu