Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix query on namespace label changes and organization change #112

Merged
merged 2 commits into from Dec 22, 2022
Merged

Fix query on namespace label changes and organization change #112

merged 2 commits into from Dec 22, 2022

Conversation

bastjan
Copy link
Contributor

@bastjan bastjan commented Dec 22, 2022 •
edited

Changes to namespace labels and organization changes can lead to many-to-many matching errors

bottomk(1,
  min by (cluster_id, namespace, tenant_id) (
    _INFO_SERIES
  )
) by(cluster_id, namespace)

Chooses a random tenant_id for every point if there is an overlap.

Checklist

  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog
  • Update tests.

@bastjan bastjan added the bug Something isn't working label Dec 22, 2022
@bastjan bastjan requested a review from a team December 22, 2022 11:00
@bastjan bastjan self-assigned this Dec 22, 2022
corvus-ch
corvus-ch approved these changes Dec 22, 2022
View reviewed changes
Copy link
Member

@corvus-ch corvus-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, please drop superfluous elements.

pkg/db/seeds/promtest/appuio_cloud_loadbalancer.jsonnet Outdated Show resolved Hide resolved
pkg/db/seeds/promtest/appuio_cloud_loadbalancer.jsonnet Outdated Show resolved Hide resolved
pkg/db/seeds/promtest/appuio_cloud_loadbalancer.jsonnet Outdated Show resolved Hide resolved
pkg/db/seeds/promtest/appuio_cloud_loadbalancer.jsonnet Outdated Show resolved Hide resolved
pkg/db/seeds/promtest/appuio_cloud_memory.jsonnet Outdated Show resolved Hide resolved
pkg/db/seeds/promtest/appuio_cloud_persistent_storage.jsonnet Outdated Show resolved Hide resolved
pkg/db/seeds/promtest/appuio_cloud_persistent_storage.jsonnet Outdated Show resolved Hide resolved
pkg/db/seeds/promtest/appuio_cloud_persistent_storage.jsonnet Outdated Show resolved Hide resolved
pkg/db/seeds/promtest/appuio_cloud_persistent_storage.jsonnet Outdated Show resolved Hide resolved
pkg/db/seeds/promtest/appuio_cloud_persistent_storage.jsonnet Outdated Show resolved Hide resolved
Base automatically changed from fix-query-on-pv-info-change to master December 22, 2022 13:30
@bastjan
Fix query on namespace label changes and organization change
1f0754a 
Changes to namespace labels and organization changes can lead to many-to-many matching errors
@bastjan bastjan force-pushed the fix-query-ns-label-org-changes branch from 68928e4 to c9b2659 Compare December 22, 2022 13:37
@bastjan bastjan force-pushed the fix-query-ns-label-org-changes branch from 69e9acd to 46a095b Compare December 22, 2022 14:55
@bastjan bastjan merged commit 4a1df2f into master Dec 22, 2022
@bastjan bastjan deleted the fix-query-ns-label-org-changes branch December 22, 2022 15:00
@bastjan bastjan mentioned this pull request Dec 23, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corvus-ch corvus-ch corvus-ch approved these changes

Assignees

@bastjan bastjan

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bastjan @corvus-ch