Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] ValidatorConfig inconsistency between Move type, aptos crate and types crate #13152

Open
so-schen opened this issue May 1, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@so-schen
Copy link
Contributor

so-schen commented May 1, 2024

馃悰 Bug

Regarding consensus_public_key of ValidatorConfig resource defined in Move contract is vector,
while in Rust
in types crate, it has type bls12381::PublicKey
in aptos crate, it as Vec.

To reproduce

If before calling rotate consensus key, we try to read ValidatorConfig on-chain, it will fail to deserailze because it is initialized as empty vector, while we try to deserialize into bls12381::PublicKey

Expected Behavior

should update ValidatorConfig in types consistent with Move type, and aptos cli crate can reuse same type to avoid confusion

System information

version v.1.10, should also exist in latest codes

@so-schen so-schen added the bug Something isn't working label May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant