Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add goark/gnkf #10446

Merged
merged 2 commits into from Mar 6, 2023
Merged

Conversation

ponkio-o
Copy link
Sponsor Contributor

@ponkio-o ponkio-o commented Mar 5, 2023

#10446 goark/gnkf: Network Kanji Filter by Golang

$ aqua g -i goark/gnkf

How to confirm if this package works well

Reviewers aren't necessarily familiar with this package, so please describe how to confirm if this package works well. Please confirm if this package works well yourself as much as possible.

Command and output

$ gnkf --help
Network Kanji Filter by Golang

Usage:
  gnkf [flags]
  gnkf [command]

Available Commands:
  base64      Encode/Decode BASE64
  bcrypt      Hash and compare by BCrypt
  completion  Generate completion script
  dump        Hexadecimal view of octet data stream
  enc         Convert character encoding of the text
  guess       Guess character encoding of the text
  hash        Print or check hash value
  help        Help about any command
  kana        Convert kana characters in the text
  newline     Convert newline form in the text
  norm        Unicode normalization of the text
  remove-bom  Remove BOM character in UTF-8 string
  version     Print the version number
  width       Convert character width in the text

Flags:
      --debug   for debug
  -h, --help    help for gnkf

Use "gnkf [command] --help" for more information about a command.
$ echo おはよう | gnkf guess
UTF-8

Reference

[goark/gnkf](https://github.com/goark/gnkf): Network Kanji Filter by Golang

```console
$ aqua g -i goark/gnkf
```

## How to confirm if this package works well

Reviewers aren't necessarily familiar with this package, so please describe how to confirm if this package works well.
Please confirm if this package works well yourself as much as possible.

Command and output

```console
$
```

If files such as configuration file are needed, please share them.

```
```

Reference

-
@ponkio-o
Copy link
Sponsor Contributor Author

ponkio-o commented Mar 5, 2023

umm...
Is it the effect of the gnkf_0.7.4_checksums.txt file name contains space?

$ cat gnkf_0.7.4_checksums.txt
1226a3a1ffdd2e9bd85428192afeb2959b6605e76ae15096b9253247db8ba034  gnkf_ 0.7.4_Linux_RICSV.tar.gz
4de1691de6d9a29089fe8cb05a8d4373c2c4ea34c397bc8b492990107a74da6f  gnkf_ 0.7.4_Darwin_ARM64.tar.gz
5b9da37c336db81a2699df66eacd934b578d4b0de3d730ab3b6ee15f907db30a  gnkf_ 0.7.4_Windows_ARM64.zip
5eb9de3117153f28082abed2a112dfbfa80b87b4920e4c6ba08ad5a0bffb0726  gnkf_ 0.7.4_Windows_64bit.zip
87d06e51e0715a0153ea0841616b9f1f783a20afb590e11369d9a39c04f84403  gnkf_ 0.7.4_Darwin_64bit.tar.gz
acd4ba0cb3a0a14bcfcd0debb9c7a2ade8a8182169a70da12a75b72650b218e4  gnkf_ 0.7.4_Freebsd_ARM64.tar.gz
c049e899c986adf4f7134cd3e0639cb968a538ea225bacf5c225c22e09408cc8  gnkf_ 0.7.4_Linux_ARM64.tar.gz
c12473b392d0b23dc77cfcd37e74e2100f02534e5273911f53985a0b7683c8ed  gnkf_ 0.7.4_Linux_64bit.tar.gz
d58dc426c5e17c82498fb45bd2301e1b2c9c13de2894e66a1d40114549725f48  gnkf_ 0.7.4_Freebsd_64bit.tar.gz

@CrystalMethod
Copy link
Contributor

\S - matches anything other than a space, tab or newline

what about ^\\b[A-Fa-f0-9]{64}\\b\\s+(gnkf_ \\S+)$ ?

@suzuki-shunsuke suzuki-shunsuke added the enhancement New feature or request label Mar 6, 2023
@suzuki-shunsuke suzuki-shunsuke added this to the v3.140.0 milestone Mar 6, 2023
@suzuki-shunsuke
Copy link
Member

suzuki-shunsuke commented Mar 6, 2023

\S - matches anything other than a space, tab or newline

what about ^\\b[A-Fa-f0-9]{64}\\b\\s+(gnkf_ \\S+)$ ?

.pattern.file must match with the asset name, so this doesn't work.

@suzuki-shunsuke
Copy link
Member

I think we have to disable checksum for v0.7.4.
I'll take a look checksum files for other than v0.7.4.

@suzuki-shunsuke
Copy link
Member

suzuki-shunsuke commented Mar 6, 2023

⭕ v0.7.6 v0.7.5 v0.7.3
❌ v0.7.4

I guess this bug was caused by v0.7.4 goark/gnkf@413ccef and was fixed by v0.7.5 goark/gnkf@998b6fc

So we should disable checksum only for v0.7.4.

@suzuki-shunsuke suzuki-shunsuke merged commit 80a9ddc into aquaproj:main Mar 6, 2023
@suzuki-shunsuke
Copy link
Member

@ponkio-o
Copy link
Sponsor Contributor Author

ponkio-o commented Mar 6, 2023

Thanks for correcting my PR.

@ponkio-o ponkio-o deleted the feat/goark/gnkf branch March 6, 2023 01:34
@CrystalMethod
Copy link
Contributor

.pattern.file must match with the asset name, so this doesn't work.

You are so right. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants