Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add mvisonneau/vac #11364

Merged
merged 2 commits into from Apr 11, 2023
Merged

Conversation

ponkio-o
Copy link
Sponsor Contributor

@ponkio-o ponkio-o commented Apr 11, 2023

#11364 mvisonneau/vac: AWS credentials management leveraging Vault

$ aqua g -i mvisonneau/vac

How to confirm if this package works well

Reviewers aren't necessarily familiar with this package, so please describe how to confirm if this package works well.
Please confirm if this package works well yourself as much as possible.

Command and output

$ vac --help
NAME:
   vac - Manage AWS credentials dynamically using Vault

USAGE:
   vac [global options] command [command options] [arguments...]

VERSION:
   0.0.8

COMMANDS:
   get      get the creds in credential_process format (json)
   status   returns some info about the current context, cached credentials and Vault server connectivity
   help, h  Shows a list of commands or help for one command

GLOBAL OPTIONS:
   --engine path, -e path  engine path [$VAC_ENGINE]
   --role name, -r name    role name [$VAC_ROLE]
   --state path, -s path   state path (default: "~/.vac_state") [$VAC_STATE_PATH]
   --log-level level       log level (debug,info,warn,fatal,panic) (default: "info") [$VAC_LOG_LEVEL]
   --log-format format     log format (json,text) (default: "text") [$VAC_LOG_FORMAT]
   --help, -h              show help (default: false)
   --version, -v           print the version (default: false)

Reference

[mvisonneau/vac](https://github.com/mvisonneau/vac): AWS credentials management leveraging Vault
@ponkio-o
Copy link
Sponsor Contributor Author

ERRO[0000] evaluate version constraints                  aqua_version=2.3.1 env=linux/amd64 error="evaluate the expression: Malformed version: edge (1:1)\n | semver(\">= 0.0.6\")\n | ^" package_name=mvisonneau/vac package_version=edge program=aqua registry=standard

@ponkio-o
Copy link
Sponsor Contributor Author

ponkio-o commented Apr 11, 2023

It's displayed correctly.

  0.0.1                                                    │
  0.0.2                                                    │
  0.0.3                                                    │
  0.0.4                                                    │
  v0.0.5                                                   │
  v0.0.6                                                   │
  v0.0.7                                                   │
> v0.0.8                                                   │
  8/8                                                      │
>                                                          └ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─ ─

@suzuki-shunsuke suzuki-shunsuke added the enhancement New feature or request label Apr 11, 2023
@suzuki-shunsuke suzuki-shunsuke added this to the v3.153.0 milestone Apr 11, 2023
@suzuki-shunsuke
Copy link
Member

Thank you always!

@suzuki-shunsuke
Copy link
Member

Hmm. aqua can't handle the error.
I created an issue. Thank you for your report.

@ponkio-o
Copy link
Sponsor Contributor Author

Thank you!

I also tried using generate-registry-deep, but it wasn't configured correctly.

https://github.com/ponkio-o/generate-registry-deep/actions/runs/4662794755

...omitted
 version_overrides:
      - version_constraint: semver(">= 0.0.5")
        rosetta2: true
      - version_constraint: Version >= "edge"  # unnecessary
      - version_constraint: semver(">= 0.0.4")
...

@suzuki-shunsuke suzuki-shunsuke merged commit 7804c09 into aquaproj:main Apr 11, 2023
16 checks passed
@suzuki-shunsuke
Copy link
Member

Hmm. aqua can't handle the error. I created an issue. Thank you for your report.

Fixed and released.

@suzuki-shunsuke
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants