Add pre-commit / pre-commit-terraform

[Gowiem]

package name

pre-commit/pre-commit
pre-commit/pre-commit-terraform

Overview

These are two packages that I saw as missing and figured I'd open this up for discussion. Are there any heavy python / pip installed packages that aqua manages today? That seems to be the requirement for both of these as their main installation method is pip.

Reference

• https://pre-commit.com/

[suzuki-shunsuke]

Thank you for opening the issue.

aqua doesn't support running external commands such as pip install.

This limitation is a design of aqua.

https://aquaproj.github.io/docs/reference/restriction/#aqua-doesnt-support-running-any-external-commands-to-install-tools

[suzuki-shunsuke]

Maybe aqua can support pip install.
I'll consider it.

• Support installing packages by pip install aqua#2128

[Gowiem]

@suzuki-shunsuke if it's possible, I think that would unlock a lot of important packages that folks will be requesting as aqua gains more traction 💯

[suzuki-shunsuke]

We're working on supporting pre-commit (pypi packages) on aquaproj/aqua#2128 ,
but I'm not sure if aqua can support pre-commit-terraform.

I'm not familiar with this tool, but I read https://github.com/antonbabenko/pre-commit-terraform#how-to-install .
In the document, pre-commit-terraform is installed by adding pre-commit-terraform to .pre-commit-config.yaml and running pre-commit run -a.

What do you think?

[nikolay]

@Gowiem @suzuki-shunsuke This is precisely how I install it declaratively, too - by adding it to .pre-commit-config.yaml and then pre-commit automatically installs, upgrades, etc.

[suzuki-shunsuke]

Then pre-commit-terraform is managed by pre-commit, so aqua doesn't have to support pre-commit-terraform.
Is it correct?

[nikolay]

@suzuki-shunsuke Correct!