Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(awslabs/amazon-ecr-credential-helper): added checksum and rosetta2 #15996

Conversation

ponkio-o
Copy link
Sponsor Contributor

@ponkio-o ponkio-o commented Oct 5, 2023

Some functionality fixes have been added.

@suzuki-shunsuke suzuki-shunsuke added this to the v4.58.0 milestone Oct 5, 2023
@suzuki-shunsuke
Copy link
Member

Thank you!

@suzuki-shunsuke
Copy link
Member

ERRO[0000] install the package                           aqua_version=2.12.1
download_url="https://amazon-ecr-credential-helper-releases.s3.us-east-2.amazonaws.com/0.3.0/linux-amd64/docker-credential-ecr-login"
env=linux/amd64
error="download a package: status code >= 400"
http_status_code=403
package_name=awslabs/amazon-ecr-credential-helper
package_version=v0.3.0
program=aqua registry=standard

https://github.com/aquaproj/aqua-registry/actions/runs/6414128345/job/17414071257?pr=15996

@ponkio-o
Copy link
Sponsor Contributor Author

ponkio-o commented Oct 5, 2023

🤔

ERRO[0001] install the package                           aqua_version=2.12.1 asset_name=docker-credential-ecr-login.exe env=windows/amd64 error="download a checksum file: unknown checksum type" package_name=awslabs/amazon-ecr-credential-helper package_type=http package_version=v0.7.1 program=aqua registry=standard

https://github.com/aquaproj/aqua-registry/actions/runs/6414273677/job/17414415337?pr=15996

@suzuki-shunsuke
Copy link
Member

suzuki-shunsuke commented Oct 5, 2023

It's confusing, but aqua overrides whole checksum.
aqua doesn't merge checksum settings.
So we need to define type and algorithm.

Fixed. 46a706a

@suzuki-shunsuke suzuki-shunsuke merged commit 461e496 into aquaproj:main Oct 5, 2023
16 checks passed
@ponkio-o
Copy link
Sponsor Contributor Author

ponkio-o commented Oct 5, 2023

It's confusing, but aqua overrides whole checksum.
aqua doesn't merge checksum settings.
So we need to define type and algorithm.

I see. Thank you for your correcting and follow up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants