Add support for github.com/michidk/vscli

[nikolay]

https://github.com/michidk/vscli
https://github.com/michidk/vscli/releases

[suzuki-shunsuke]

Thank you.

• feat: add michidk/vscli #16499

[suzuki-shunsuke]

v4.71.0 is out 🎉
https://github.com/aquaproj/aqua-registry/releases/tag/v4.71.0

[nikolay]

Thank you, @suzuki-shunsuke, but I get this error on Apple Silicon:

INFO[0000] downloading an asset to calculate the checksum  aqua_version=2.15.0 asset_name=vscli-x86_64-unknown-linux-musl.tar.gz checksum_env=linux/amd64 env=darwin/arm64 package_name=michidk/vscli package_registry=standard package_version="[SET PACKAGE VERSION]" program=aqua
ERRO[0001] update checksums                              aqua_version=2.15.0 asset_name=vscli-x86_64-unknown-linux-musl.tar.gz env=darwin/arm64 error="download an asset: get the GitHub Release by Tag: GET https://api.github.com/repos/michidk/vscli/releases/tags/%5BSET%20PACKAGE%20VERSION%5D: 404 Not Found []" package_name=michidk/vscli package_registry=standard package_version="[SET PACKAGE VERSION]" program=aqua
FATA[0001] aqua failed                                   aqua_version=2.15.0 env=darwin/arm64 error="it failed to update some packages' checksums" program=aqua

[suzuki-shunsuke]

package_version="[SET PACKAGE VERSION]"

version looks strange. Please check.

[suzuki-shunsuke]

aqua g can get the latest version correctly, so [SET PACKAGE VERSION] is strange.

$ aqua g michidk/vscli
- name: michidk/vscli@v0.1.10

Does GitHub API rate limiting occur? If so, aqua can't get the latest version and version would become [SET PACKAGE VERSION].

[nikolay]

I have AQUA_GITHUB_TOKEN set. This is what I have in my aqua.yaml:

- name: michidk/vscli@v0.1.10

[nikolay]

Oh, @suzuki-shunsuke, I just noticed that aqua g -i michidk/vscli has added that! But I have earlier in the file the above pinned version! Wasn't aqua g -i michidk/vscli supposed to install the latest version?

[suzuki-shunsuke]

aqua g -i michidk/vscli should add the latest version.

[suzuki-shunsuke]

I'm not sure why [SET PACKAGE VERSION] was set.
Maybe GitHub API returned an error due to some reason.
Anyway, could you fix the version?

[nikolay]

@suzuki-shunsuke Yes, I fixed it. You probably are correct (as always!). I did add the token after aqua g -i, but, in such case, the best would be to leave the version empty and not add an invalid one. Or if aqua always requires a version, the whole CLI fails with an error instead of adding something that breaks the entire thing. Thank you again for being an exemplary maintainer!

[suzuki-shunsuke]

in such case, the best would be to leave the version empty and not add an invalid one. Or if aqua always requires a version, the whole CLI fails with an error instead of adding something that breaks the entire thing.

Yeah, I agree. We can improve the behavior as you said. I'll create an Issue for it.

[suzuki-shunsuke]

• Improve the behavior when packages' latest versions can't be gotten aqua#2374