Skip to content

chore(cmdx): fix cmdx remove to be able to delete Docker container #17528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 20, 2023
Merged

chore(cmdx): fix cmdx remove to be able to delete Docker container #17528

merged 1 commit into from
Nov 20, 2023

Conversation

hituzi-no-sippo
Copy link
Contributor

When the shell is not set, an error with sh will occur.

$ cmdx remove
+ set -euxo pipefail
docker stop -t 1 aqua-registry
docker rm aqua-registry

sh: 1: set: Illegal option -o pipefail
exit status 2

cmdx.yaml Outdated
@@ -153,6 +153,9 @@ tasks:
Remove the container.
$ cmdx rm
shell:
- "bash"
- "-c"
script: |
set -euxo pipefail
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
set -euxo pipefail
set -eux

Copy link
Member

@suzuki-shunsuke suzuki-shunsuke Nov 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can simply remove the option -o pipefail.
This task doesn't use a pipe.

@suzuki-shunsuke
Copy link
Member

Thank you for your contribution!

@suzuki-shunsuke suzuki-shunsuke added this to the v4.90.1 milestone Nov 20, 2023
@suzuki-shunsuke suzuki-shunsuke merged commit 6928db2 into aquaproj:main Nov 20, 2023
@hituzi-no-sippo hituzi-no-sippo deleted the chore/fix-cmdx-remove-to-be-able-to-delet-docker-container branch November 20, 2023 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants