fix(atuinsh/atuin): use musl builds instead of gnu when available #18523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution! |
|
v4.111.0 is out 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the gnu build of
atuinsh/atuinon Linux with the musl build, in order to follow the Aqua Registry Style Guide's recommendations on gnu vs musl. musl Linux builds are only available for atuin starting in release v14.0.0; in v13.0.1 and earlier, only gnu Linux builds were available. Thus, this PR changes the atuin package'sregistry.yamlfile so that aqua downloads the musl Linux build for v14.0.0 and above, but still downloads the gnu Linux build for v13.0.1 and below.I'm not sure what level of testing is needed for this PR, but I tested out this change in an Alpine Linux Distrobox container and it resolved a glibc-vs.-musl error I had previously been getting from Aqua when trying to run atuin in that container; with this change, atuin v14.0.0 and above run properly without that error.