Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add tummychow/git-absorb #19890

Merged
merged 4 commits into from
Feb 12, 2024
Merged

feat: add tummychow/git-absorb #19890

merged 4 commits into from
Feb 12, 2024
+137 −0

Conversation

haya14busa
Copy link
Contributor

@haya14busa haya14busa commented Feb 12, 2024 •
edited by suzuki-shunsuke
Loading

#19890 tummychow/git-absorb: git commit --fixup, but automatic

@suzuki-shunsuke suzuki-shunsuke added the enhancement New feature or request label Feb 12, 2024
@suzuki-shunsuke suzuki-shunsuke added this to the v4.132.0 milestone Feb 12, 2024
@suzuki-shunsuke
Copy link
Member

Thank you for your contribution!

@suzuki-shunsuke
fix(tummychow/git-absorb): remove a newline and run cmdx gr

Verified

This commit was signed with the committer’s verified signature. The key has expired.
suzuki-shunsuke Shunsuke Suzuki
GPG key ID: 8C1396BBB3626865
Expired
Verified
Learn about vigilant mode
a88db26
@suzuki-shunsuke
Copy link
Member

a88db26

suzuki-shunsuke
suzuki-shunsuke reviewed Feb 12, 2024
View reviewed changes
pkgs/tummychow/git-absorb/pkg.yaml
@@ -0,0 +1,2 @@
packiages:
- name: tummychow/git-absorb@0.6.11
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pkg.yaml scaffolded by cmdx s should have included not only the latest version but also old versions.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

c3385c4 Added testdata by cmdx s tummychow/git-absorb.

@suzuki-shunsuke
Copy link
Member 

$ aqua which git-absorb
FATA[0000] aqua failed                                   aqua_version=2.23.1 doc="https://aquaproj.github.io/docs/reference/codes/004" env=darwin/arm64 error="command is not found" exe_name=git-absorb program=aqua

It's strange.
Maybe this is an issue of aqua, but I'm taking a look.

suzuki-shunsuke
suzuki-shunsuke reviewed Feb 12, 2024
View reviewed changes
pkgs/tummychow/git-absorb/pkg.yaml Outdated
@@ -0,0 +1,2 @@
packiages:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
packiages:
packages:

Oh, I see.
This is a typo.

@suzuki-shunsuke
Copy link
Member

📝 Looks good.

https://github.com/tummychow/git-absorb?tab=readme-ov-file#installing

The easiest way to install git absorb is to download an artifact from the latest tagged release. Artifacts are available for Windows, MacOS, and Linux (built on Ubuntu with statically linked libgit2).

@suzuki-shunsuke suzuki-shunsuke merged commit bbc0639 into aquaproj:main Feb 12, 2024
@suzuki-shunsuke
Copy link
Member

v4.132.0 is out 🎉
https://github.com/aquaproj/aqua-registry/releases/tag/v4.132.0

@haya14busa haya14busa deleted the add-git-absorb branch February 12, 2024 11:49
@haya14busa
Copy link
Contributor Author

Thank you for your work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suzuki-shunsuke suzuki-shunsuke

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v4.132.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@haya14busa @suzuki-shunsuke