Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add iamhsa/pkenv #20284

Closed
bhundven opened this issue Feb 23, 2024 · 9 comments · Fixed by #20287
Closed

Add iamhsa/pkenv #20284

bhundven opened this issue Feb 23, 2024 · 9 comments · Fixed by #20287
Labels
enhancement New feature or request

Comments

@bhundven
Copy link
Contributor

https://github.com/iamhsa/pkenv

@suzuki-shunsuke suzuki-shunsuke added the enhancement New feature or request label Feb 23, 2024
@suzuki-shunsuke
Copy link
Member

Thank you.
I'm working on it.
Maybe you're aware, but you can manage packer with aqua too.

aqua g -i hashicorp/packer

@bhundven
Copy link
Contributor Author

Sure, we use pkenv in a docker image so you can use .packer-version, as some of our projects use different version of packer using the same docker image that uses aqua.

Aqua also provides tfenv (which pkenv is based on), as well as terraform.

@suzuki-shunsuke
Copy link
Member

suzuki-shunsuke commented Feb 23, 2024

I see.

I created a pull request to support pkenv. #20287
I noticed the issue that every time you update pkenv you need to install Packer.
Please see the pull request description. #20287 (comment)

@suzuki-shunsuke
Copy link
Member

The same issue occurs If we manage tfenv with aqua.
It can't be helped.

@suzuki-shunsuke suzuki-shunsuke linked a pull request Feb 23, 2024 that will close this issue
@suzuki-shunsuke
Copy link
Member

v4.141.0 is out 🎉
https://github.com/aquaproj/aqua-registry/releases/tag/v4.141.0

@bhundven
Copy link
Contributor Author

bhundven commented Feb 24, 2024

Just curious, when I try using aqua with tfenv or pkenv, and following this guide:
https://aquaproj.github.io/docs/guides/build-container-image#remove-aqua-from-image
The tfenv and pkenv commands are in lib and libexec of the package. Is there a way to handle this?

@suzuki-shunsuke
Copy link
Member

https://aquaproj.github.io/docs/guides/build-container-image/#notes-of-aqua-cp

aqua cp doesn't work for tfenv and pkenv well.
So if you want to install them in Docker images and don't want to keep aqua in images,
we don't recommend aqua to install them.

@bhundven
Copy link
Contributor Author

I might work on an option for cp for this kind of thing.

@suzuki-shunsuke
Copy link
Member

Thank you.
If you come up with an idea about it, please open a discussion.

https://github.com/orgs/aquaproj/discussions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants