Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add crates.io/gitu #20854

Merged
merged 2 commits into from
Mar 13, 2024
Merged

Conversation

ryoppippi
Copy link
Contributor

@ryoppippi ryoppippi commented Mar 13, 2024

crates.io/gitu: A TUI Git client inspired by Magit

@ryoppippi ryoppippi closed this Mar 13, 2024
@ryoppippi ryoppippi deleted the feat/altsem/gitu branch March 13, 2024 07:15
@ryoppippi ryoppippi restored the feat/altsem/gitu branch March 13, 2024 07:15
@ryoppippi ryoppippi reopened this Mar 13, 2024
[altsem/gitu](https://github.com/altsem/gitu): A TUI Git client inspired by Magit
@suzuki-shunsuke
Copy link
Member

suzuki-shunsuke commented Mar 13, 2024

Thank you for your contribution!

The package name of cargo package must start with crates.io.

https://aquaproj.github.io/docs/develop-registry/registry-style-guide/#cargo-package-name-should-be-cratesiocrate-name

https://github.com/aquaproj/aqua-registry/tree/main/pkgs/crates.io

I renamed the package to crates.io/gitu.

@suzuki-shunsuke suzuki-shunsuke added the enhancement New feature or request label Mar 13, 2024
@suzuki-shunsuke
Copy link
Member

suzuki-shunsuke commented Mar 13, 2024

Hmm. It fails to get metadata by crates.io API. 🤔

$ aqua gr crates.io/gitu
WARN[0000] get a crate metadata by crates.io API         aqua_version=2.24.0 env=darwin/arm64 error="HTTP status code is greater equal than 300" program=aqua
WARN[0000] get a latest version by crates.io API         aqua_version=2.24.0 env=darwin/arm64 error="HTTP status code is greater equal than 300" program=aqua
packages:
  - name: crates.io/gitu
    type: cargo
    crate: gitu

This issue occurs with other package.

$ aqua gr crates.io/skim
WARN[0000] get a crate metadata by crates.io API         aqua_version=2.24.0 env=darwin/arm64 error="HTTP status code is greater equal than 300" program=aqua
WARN[0000] get a latest version by crates.io API         aqua_version=2.24.0 env=darwin/arm64 error="HTTP status code is greater equal than 300" program=aqua
packages:
  - name: crates.io/skim
    type: cargo
    crate: skim

Was crates.io API changed?

@suzuki-shunsuke suzuki-shunsuke added this to the v4.151.1 milestone Mar 13, 2024
@suzuki-shunsuke
Copy link
Member

aqua can't get the latest version by crates.io API.
I'll look into this.

$ aqua g crates.io/skim
WARN[0000] retrieve package versions                     aqua_version=2.24.0 env=darwin/arm64 error="HTTP status code is greater equal than 300" program=aqua repository=lotabout/skim
- name: crates.io/skim
  version: '[SET PACKAGE VERSION]'

@suzuki-shunsuke
Copy link
Member

This package provides pre-release binaries for some platforms.

https://github.com/altsem/gitu/releases

We should use them too.

@suzuki-shunsuke
Copy link
Member

Oh, I see. The version format of GitHub Releases is different from the format of crates.io.

GitHub Release: v0.6.2
crates.io: 0.6.2

So it's difficult to support both at the moment.
We should resolve the issue by improving aqua in future.

Anyway, we give up using github_release now.

@suzuki-shunsuke suzuki-shunsuke merged commit b3aef3b into aquaproj:main Mar 13, 2024
16 checks passed
@suzuki-shunsuke suzuki-shunsuke changed the title feat: add altsem/gitu feat: add crates.io/gitu Mar 13, 2024
@ryoppippi
Copy link
Contributor Author

Thanks!!

@ryoppippi ryoppippi deleted the feat/altsem/gitu branch March 13, 2024 09:12
@suzuki-shunsuke
Copy link
Member

I resolved the issue regarding crates.io API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants