Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: jetstack/cert-manager/cmctl to cert-manager/cert-manager/cmctl #7008

Merged

Conversation

ponkio-o
Copy link
Sponsor Contributor

@ponkio-o ponkio-o commented Oct 12, 2022

#7008 Rename the package jetstack/cert-manager/cmctl to cert-manager/cert-manager/cmctl

The repository jetstack/cert-manager has been transferred to cert-manager/cert-manager.

@suzuki-shunsuke
Copy link
Member

Thank you always!

@suzuki-shunsuke suzuki-shunsuke added this to the v3.74.1 milestone Oct 12, 2022
@suzuki-shunsuke suzuki-shunsuke changed the title chore: jetstack/cert-manager to cert-manager/cert-manager chore: jetstack/cert-manager/cmctl to cert-manager/cert-manager Oct 12, 2022
@suzuki-shunsuke

This comment was marked as duplicate.

Copy link
Member

@suzuki-shunsuke suzuki-shunsuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the package name should be not cert-manager/cert-manager but cert-manager/cert-manager/cmctl.

@ponkio-o
Copy link
Sponsor Contributor Author

Fixed in the following commit.
885dc18

And I don't really understand why this fix is necessary. 🤔

@suzuki-shunsuke
Copy link
Member

suzuki-shunsuke commented Oct 13, 2022

And I don't really understand why this fix is necessary.

Actually, there is no strict rule about the package name, so cert-manager/cert-manager isn't necessarily wrong.
But I think users should be able to understand what is installed by the package.

In case of cert-manager, I think cert-manager means a resource working on Kubernetes rather than CLI.

https://cert-manager.io/

cert-manager is a powerful and extensible X.509 certificate controller for Kubernetes and OpenShift workloads.

So users may misunderstand or be confused.

The package name cert-manager/cert-manager/cmctl is easy to understand.

@ponkio-o
Copy link
Sponsor Contributor Author

Actually, there is no strict rule about the package name, so cert-manager/cert-manager isn't necessarily wrong.
But I think users should be able to understand what is installed by the package.

Thank you! I understood.

@suzuki-shunsuke
Copy link
Member

I know some packages don't follow this idea, so this isn't a strict policy.
I have an idea to set aliases to existing packages to follow this idea strictly, but there is no plan to execute it at the moment.

@suzuki-shunsuke suzuki-shunsuke merged commit dee4fbb into aquaproj:main Oct 13, 2022
@suzuki-shunsuke suzuki-shunsuke changed the title chore: jetstack/cert-manager/cmctl to cert-manager/cert-manager chore: jetstack/cert-manager/cmctl to cert-manager/cert-manager/cmctl Oct 14, 2022
@suzuki-shunsuke
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants