refactor(kubernetes/kubectl): change download url #7085
Conversation
- apply style guide - support current release - https://www.downloadkubernetes.com
|
Thanks! |
pkgs/kubernetes/kubectl/pkg.yaml
Outdated
| - name: kubernetes/kubectl@v1.24.7 | ||
| - name: kubernetes/kubectl@v1.23.13 | ||
| - name: kubernetes/kubectl@v1.22.15 |
There was a problem hiding this comment.
| - name: kubernetes/kubectl@v1.24.7 | |
| - name: kubernetes/kubectl@v1.23.13 | |
| - name: kubernetes/kubectl@v1.22.15 | |
| - name: kubernetes/kubectl | |
| version: v1.22.15 |
We test version_overrides with multiple versions.
So the number of versions should be same as version_constraint.
| - amd64 | ||
| - version_constraint: "true" | ||
| rosetta2: true | ||
| - version_constraint: semver("< 1.23.0") |
There was a problem hiding this comment.
version_overrides has been changed. 🤔
I'm not sure why this change is needed.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Sorry, I thought about it and the only change I made to version_overrides was to add Windows. I'll revert it back to the original.
|
The update of the download url seems to be good, but I'm not sure other updates are good. |
takumin
changed the title
| format: raw | ||
| link: https://kubernetes.io/docs/reference/kubectl/overview/ |
There was a problem hiding this comment.
In this case, we should set link, because https://kubernetes.io/docs/reference/kubectl/ is better than the default link https://github.com/kubernetes/kubernetes
storage.googleapis.comdl.k8s.io