Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(git-town): 🐛 package did not handle replacements for cpu type correctly #7146

Merged
merged 4 commits into from Oct 18, 2022

Conversation

sheldonhull
Copy link
Contributor

@sheldonhull sheldonhull commented Oct 18, 2022

#7146 git-town/git-town: Fix wrong replacements


Resolve the cpu arch type not being correctly set as a templated variable.

@suzuki-shunsuke
Copy link
Member

suzuki-shunsuke commented Oct 18, 2022

Thanks!

Oh, my god.
aqua gr generated the bad configuration, but I missed it... #6889 (comment)

$ aqua gr git-town/git-town
packages:
  - type: github_release
    repo_owner: git-town
    repo_name: git-town
    asset: git-town_{{trimV .Version}}_{{.OS}}_arm_64.{{.Format}}
    format: tar.gz
    description: Generic, high-level Git workflow support
    replacements:
      darwin: macos
    overrides:
      - goos: windows
        format: zip
        asset: git-town_{{trimV .Version}}_{{.OS}}_intel_64.{{.Format}}
    supported_envs:
      - darwin
      - amd64
    rosetta2: true

@suzuki-shunsuke suzuki-shunsuke added the bug Something isn't working label Oct 18, 2022
@suzuki-shunsuke suzuki-shunsuke added this to the v3.76.2 milestone Oct 18, 2022
@suzuki-shunsuke suzuki-shunsuke merged commit ef9ae8f into aquaproj:main Oct 18, 2022
@suzuki-shunsuke
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants