Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add wakatime/wakatime-cli #7312

Merged

Conversation

CrystalMethod
Copy link
Contributor

wakatime/wakatime-cli: Command line interface used by all WakaTime text editor plugins

$ aqua g -i wakatime/wakatime-cli

[wakatime/wakatime-cli](https://github.com/wakatime/wakatime-cli): Command line interface used by all WakaTime text editor plugins

```console
$ aqua g -i wakatime/wakatime-cli
```

## How to confirm if this package works well

Reviewers aren't necessarily familiar with this package, so please describe how to confirm if this package works well.
Please confirm if this package works well yourself as much as possible.

Command and output

```console
$
```

If files such as configuration file are needed, please share them.

```
```

Reference

-
@CrystalMethod
Copy link
Contributor Author

#7315

@suzuki-shunsuke
Copy link
Member

Thank you for your contribution!

@suzuki-shunsuke suzuki-shunsuke added the enhancement New feature or request label Oct 23, 2022
@suzuki-shunsuke suzuki-shunsuke added this to the v3.80.1 milestone Oct 23, 2022
@suzuki-shunsuke
Copy link
Member

I'm not familiar with this tool, so I'm checking if aqua can support this.

I can't find the document about how akatime-cli works, but it seems that wakatime-cli should be installed in not PATH but $HOME/.wakatime/wakatime-cli.

https://github.com/wakatime/vim-wakatime/blob/4692ec3e77ade9e65171182296cca74352a39a12/plugin/wakatime.vim#L217

I usually use NeoVim, so I'm trying https://github.com/wakatime/vim-wakatime .
This plugin installs wakatime-cli to $HOME/.wakatime/wakatime-cli.

aqua doesn't support installing commands in other than PATH, but you can solve the problem with symbolic links.

$ rm $HOME/.wakatime/wakatime-cli $HOME/.wakatime/wakatime-cli-darwin-arm64 # Remove commands installed by NeoVim Plugin

$ which wakatime-cli
/Users/shunsukesuzuki/.local/share/aquaproj-aqua/bin/wakatime-cli

$ ln -s "$(which wakatime-cli)" ~/.wakatime/wakatime-cli # Create a symbolic link

Then I've confirmed wakatime-cli (NeoVim Plugin) works well.

In case of Windows, I guess symbolic link doesn't work well, so you have to create scripts instead of symbolic links.
Please see https://aquaproj.github.io/docs/reference/windows-support#create-bat-files-and-shell-scripts-instead-of-symbolic-links-and-aqua-proxy .

@suzuki-shunsuke suzuki-shunsuke linked an issue Oct 23, 2022 that may be closed by this pull request
@CrystalMethod
Copy link
Contributor Author

I did not use the vim plugin so far. But as far as I can see you can disable the "embedded wakatime-cli" by setting wakatime_CLIPath

using lua:

vim.g.wakatime_CLIPath = ".."

or using vimscript:

let g:wakatime_CLIPath = ".."

@suzuki-shunsuke
Copy link
Member

How do you use wakatime-cli? Do you execute wakatime-cli directly in your terminal?

@suzuki-shunsuke
Copy link
Member

Anyway, I think aqua can support wakatime-cli and this pull request looks good to me.
Thanks!

@suzuki-shunsuke suzuki-shunsuke merged commit 79985a0 into aquaproj:main Oct 24, 2022
@suzuki-shunsuke
Copy link
Member

@CrystalMethod CrystalMethod deleted the feat/wakatime/wakatime-cli branch November 23, 2022 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add wakatime-cli
2 participants