Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add bitwarden/clients #7317

Merged
merged 4 commits into from Oct 24, 2022
Merged

feat: add bitwarden/clients #7317

merged 4 commits into from Oct 24, 2022

Conversation

CrystalMethod
Copy link
Contributor

bitwarden/clients: Bitwarden CLI
#858
#921

$ aqua g -i bitwarden/clients

CrystalMethod and others added 2 commits October 24, 2022 00:46
@CrystalMethod
feat: add bitwarden/clients
4d30014 
[bitwarden/clients](https://github.com/bitwarden/clients): Bitwarden CLI

```console
$ aqua g -i bitwarden/clients
```

## How to confirm if this package works well

Reviewers aren't necessarily familiar with this package, so please describe how to confirm if this package works well.
Please confirm if this package works well yourself as much as possible.

Command and output

```console
$
```

If files such as configuration file are needed, please share them.

```
```

Reference

-
@CrystalMethod
Merge branch 'main' into feat/bitwarden/clients
f7cf663
@suzuki-shunsuke
Copy link
Member

Thank you!

@CrystalMethod
Copy link
Contributor Author

Btw:
I would like to use aqua g -i bitwarden/clients/cli as this reads more natural. But this does not work because the different clients assets are uploaded in separate release folders (because they are versioned independently). And as far as I understand Aqua this is currently not supported.

This works but the client is part of the version:

$ aqua g bitwarden/clients/cli
- name: bitwarden/clients/cli@cli-v2022.10.0

@suzuki-shunsuke suzuki-shunsuke added the enhancement New feature or request label Oct 23, 2022
@suzuki-shunsuke suzuki-shunsuke added this to the v3.80.1 milestone Oct 23, 2022
@suzuki-shunsuke suzuki-shunsuke mentioned this pull request Oct 24, 2022
Open
@suzuki-shunsuke
Copy link
Member

Btw: I would like to use aqua g -i bitwarden/clients/cli as this reads more natural. But this does not work because the different clients assets are uploaded in separate release folders (because they are versioned independently). And as far as I understand Aqua this is currently not supported.

This works but the client is part of the version:

$ aqua g bitwarden/clients/cli
- name: bitwarden/clients/cli@cli-v2022.10.0

Thank you for your feedback.
I've created the issue for your feedback.
I'll consider it. aquaproj/aqua#1341

@suzuki-shunsuke
Copy link
Member

e68f40c Removed unneeded quotes https://aquaproj.github.io/docs/reference/registry-style-guide#remove-unneeded-quotes-of-strings
049a15f Set checksum configuration https://aquaproj.github.io/docs/reference/checksum/

@suzuki-shunsuke suzuki-shunsuke merged commit 2c15223 into aquaproj:main Oct 24, 2022
@suzuki-shunsuke suzuki-shunsuke mentioned this pull request Oct 24, 2022
Closed
@suzuki-shunsuke
Copy link
Member

Released. https://github.com/aquaproj/aqua-registry/releases/tag/v3.81.0

@CrystalMethod CrystalMethod deleted the feat/bitwarden/clients branch November 23, 2022 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v3.81.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@CrystalMethod @suzuki-shunsuke