Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add kashav/fsql #7620

Merged
merged 3 commits into from Nov 6, 2022
Merged

feat: add kashav/fsql #7620

merged 3 commits into from Nov 6, 2022

Conversation

ponkio-o
Copy link
Sponsor Contributor

@ponkio-o ponkio-o commented Nov 5, 2022 •
edited

#7620 kashav/fsql: Search for files using a fun query language

$ aqua g -i kashav/fsql

How to confirm if this package works well

Reviewers aren't necessarily familiar with this package, so please describe how to confirm if this package works well.
Please confirm if this package works well yourself as much as possible.

Command and output

$ fsql --help
usage: /Users/username/.local/share/aquaproj-aqua/pkgs/github_release/github.com/kashav/fsql/v0.5.1/fsql-0.5.1-fsql-darwin-amd64.tar.gz/fsql-darwin-amd64/fsql [options] [query]
  -v    print version and exit (shorthand)
  -version
        print version and exit

If files such as configuration file are needed, please share them.

$ cd aqua-registry
$ fsql "SELECT name, size FROM ., -pkgs WHERE name LIKE .yaml"
.cmdx.yaml                      1258
actionlint.yaml                 479
check-files.yaml                559
generate-registry.yaml          798
json-schema.yaml                502
prettier.yaml                   288
renovate-config-validator.yaml  563
test.yaml                       2173
ci-info.yaml                    217
dev.yaml                        202
test.yaml                       185
aqua-all.yaml                   314
aqua-local.yaml                 365
aqua.yaml                       285
registry.yaml                   510375

Reference

@ponkio-o
feat: add kashav/fsql
638fba7 
[kashav/fsql](https://github.com/kashav/fsql): Search for files using a fun query language

```console
$ aqua g -i kashav/fsql
```

Reviewers aren't necessarily familiar with this package, so please describe how to confirm if this package works well.
Please confirm if this package works well yourself as much as possible.

Command and output

```console
$
```

If files such as configuration file are needed, please share them.

```
```

Reference

-

fix: added supported_envs

fix: added version_overrides

fix: files

fix: fixed asset name for old versions
@ponkio-o
Copy link
Sponsor Contributor Author

ponkio-o commented Nov 5, 2022 •
edited

For some reason, asset does not exists in v0.5.0. What should I do in such a case?
https://github.com/kashav/fsql/releases/tag/v0.5.0

@suzuki-shunsuke suzuki-shunsuke added the enhancement New feature or request label Nov 5, 2022
@suzuki-shunsuke suzuki-shunsuke added this to the v3.88.1 milestone Nov 5, 2022
@suzuki-shunsuke
Copy link
Member

Thanks!

@suzuki-shunsuke
Copy link
Member

For some reason, asset does not exists in v0.5.0. What should I do in such a case?

This is a bit difficult problem, and there is no strict policy.

  1. Do nothing (Installation would fail)
  2. Use go_install package
  3. Make supported_envs to [] (aqua ignores the package. Probably users misunderstand or are confused)
  4. Support a new feature for this case

@suzuki-shunsuke
Copy link
Member

suzuki-shunsuke commented Nov 6, 2022 •
edited

I'll fix JSON Schema. https://github.com/aquaproj/aqua-registry/actions/runs/3402202118/jobs/5657800343

@suzuki-shunsuke
Copy link
Member

suzuki-shunsuke commented Nov 6, 2022 •
edited

Fixed.

@suzuki-shunsuke suzuki-shunsuke merged commit fc8ef4d into aquaproj:main Nov 6, 2022
@suzuki-shunsuke
Copy link
Member

Released. https://github.com/aquaproj/aqua-registry/releases/tag/v3.89.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v3.89.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ponkio-o @suzuki-shunsuke