Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add bufbuild/connect-go/protoc-gen-connect-go #8760

Merged
merged 4 commits into from Dec 27, 2022
Merged

feat: add bufbuild/connect-go/protoc-gen-connect-go #8760

merged 4 commits into from Dec 27, 2022

Conversation

s-takehana
Copy link
Contributor

@s-takehana s-takehana commented Dec 27, 2022

bufbuild/connect-go/protoc-gen-connect-go: A code generation tool for Connect.

aqua g -i bufbuild/connect-go/protoc-gen-connect-go

@suzuki-shunsuke
Copy link
Member

Thank you for your contribution!

@s-takehana s-takehana marked this pull request as ready for review December 27, 2022 11:35
@s-takehana
Copy link
Contributor Author

Sorry, please review && squash merge.

@suzuki-shunsuke
Copy link
Member

Let me rename the package bufbuild/connect-go to bufbuild/connect-go/protoc-gen-connect-go to clarify the content of the package.

@s-takehana
Copy link
Contributor Author

Thank you!

@suzuki-shunsuke
Copy link
Member

And I set files to fix the command name.

    files:
      - name: protoc-gen-connect-go

@suzuki-shunsuke suzuki-shunsuke merged commit 8a675a3 into aquaproj:main Dec 27, 2022
@s-takehana s-takehana deleted the feat/connect-go branch December 27, 2022 11:44
@suzuki-shunsuke suzuki-shunsuke added this to the v3.111.0 milestone Dec 28, 2022
@suzuki-shunsuke suzuki-shunsuke changed the title feat: add bufbuild/connect-go feat: add bufbuild/connect-go/protoc-gen-connect-go Dec 28, 2022
@suzuki-shunsuke suzuki-shunsuke added the enhancement New feature or request label Dec 28, 2022
@suzuki-shunsuke
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants