feat: add bufbuild/protoc-gen-validate #8770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[bufbuild/protoc-gen-validate/protoc-gen-validate-go](https://github.com/bufbuild/protoc-gen-validate): protoc plugin to generate polyglot message validators ```console $ aqua g -i bufbuild/protoc-gen-validate/protoc-gen-validate-go ``` ## How to confirm if this package works well Reviewers aren't necessarily familiar with this package, so please describe how to confirm if this package works well. Please confirm if this package works well yourself as much as possible. Command and output ```console $ ``` If files such as configuration file are needed, please share them. ``` ``` Reference -
s-takehana
commented
Dec 28, 2022
Comment on lines
4
to
5
| aliases: | ||
| - name: envoyproxy/protoc-gen-validate |
There was a problem hiding this comment.
|
Please review. |
|
Thanks! |
| @@ -0,0 +1,11 @@ | |||
| packages: | |||
| - type: go_install | |||
There was a problem hiding this comment.
You should use github_release.
You don't have to build binaries yourself.
https://github.com/bufbuild/protoc-gen-validate/releases
|
I'll add commits. |
…date ```console $ aqua-registry scaffold bufbuild/protoc-gen-validate ```
…ufbuild/protoc-gen-validate
suzuki-shunsuke
changed the title
```console $ aqua-registry gr ```
|
https://github.com/bufbuild/protoc-gen-validate#installation
Hmm? What does it mean? Assets in GitHub Releases are unavailable? |
|
I created an issue. |
I'm not sure if we should install them in $PATH
Please follow the template as much as possible from the next time. |
|
Thank you for fixing it. |
s-takehana
deleted the
feat/bufbuild/protoc-gen-validate/protoc-gen-validate-go
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bufbuild/protoc-gen-validate: protoc plugin to generate polyglot message validators
$ aqua g -i bufbuild/protoc-gen-validate/protoc-gen-validate-goHow to confirm if this package works well
Reviewers aren't necessarily familiar with this package, so please describe how to confirm if this package works well. Please confirm if this package works well yourself as much as possible.
Command and output
If files such as configuration file are needed, please share them.
Reference