Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add vburenin/ifacemaker #8785

Merged
merged 2 commits into from Dec 29, 2022
Merged

feat: add vburenin/ifacemaker #8785

merged 2 commits into from Dec 29, 2022

Conversation

s-takehana
Copy link
Contributor

vburenin/ifacemaker: Generate interfaces from structure methods

$ aqua g -i vburenin/ifacemaker

How to confirm if this package works well

Reviewers aren't necessarily familiar with this package, so please describe how to confirm if this package works well. Please confirm if this package works well yourself as much as possible.

Command and output

$ ifacemaker --help
Usage:
  ifacemaker [OPTIONS]

Application Options:
  -f, --file=          Go source file to read, either filename or glob
  -s, --struct=        Generate an interface for this structure name
  -i, --iface=         Name of the generated interface
  -p, --pkg=           Package name for the generated interface
  -y, --iface-comment= Comment for the interface, default is '// <iface> ...'
  -d, --doc=           Copy docs from methods (default: true)
  -D, --type-doc       Copy type doc from struct
  -c, --comment=       Append comment to top, default is '// Code generated by ifacemaker; DO NOT EDIT.'
  -o, --output=        Output file name. If not provided, result will be printed to stdout.

Help Options:
  -h, --help           Show this help message

If files such as configuration file are needed, please share them.

Reference

[vburenin/ifacemaker](https://github.com/vburenin/ifacemaker): Generate interfaces from structure methods

```console
$ aqua g -i vburenin/ifacemaker
```

## How to confirm if this package works well

Reviewers aren't necessarily familiar with this package, so please describe how to confirm if this package works well.
Please confirm if this package works well yourself as much as possible.

Command and output

```console
$
```

If files such as configuration file are needed, please share them.

```
```

Reference

-
@s-takehana s-takehana marked this pull request as ready for review December 29, 2022 10:17
@s-takehana
Copy link
Contributor Author

Please review.

@suzuki-shunsuke
Copy link
Member

Thanks!

@suzuki-shunsuke suzuki-shunsuke added the enhancement New feature or request label Dec 29, 2022
@suzuki-shunsuke suzuki-shunsuke added this to the v3.112.0 milestone Dec 29, 2022
@suzuki-shunsuke
Copy link
Member

suzuki-shunsuke commented Dec 29, 2022

v1.1.0 and v1.0.0 have assets in GitHub Releases, so we should use them instead of building them from source with Go.

Fixed. d7ad88c

@suzuki-shunsuke suzuki-shunsuke merged commit b37f4ec into aquaproj:main Dec 29, 2022
@s-takehana
Copy link
Contributor Author

Thank you for your help.

@s-takehana s-takehana deleted the feat/vburenin/ifacemaker branch December 29, 2022 10:37
@suzuki-shunsuke
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants