Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add prometheus/prom2json #8815

Merged
merged 2 commits into from Dec 31, 2022
Merged

feat: add prometheus/prom2json #8815

merged 2 commits into from Dec 31, 2022

Conversation

ryodocx
Copy link
Contributor

@ryodocx ryodocx commented Dec 31, 2022

prom2json is a tool to scrape a Prometheus client and dump the result as JSON.

$ aqua g -i prometheus/prom2json

How to confirm if this package works well

Command and output

$ prom2json --help
Usage of prom2json:
  -accept-invalid-cert
        Accept any certificate during TLS handshake. Insecure, use only for testing.
  -cert string
        client certificate file
  -key string
        client certificate's key file

@suzuki-shunsuke
Copy link
Member

suzuki-shunsuke commented Dec 31, 2022 •
edited

CI failed because JSONSchema was wrong.
This problem would be solved by aquaproj/aqua#1504 .
https://github.com/aquaproj/aqua-registry/actions/runs/3810418964/jobs/6482487159

@suzuki-shunsuke
Copy link
Member

Thanks!

@suzuki-shunsuke suzuki-shunsuke added the enhancement New feature or request label Dec 31, 2022
@suzuki-shunsuke suzuki-shunsuke added this to the v3.114.0 milestone Dec 31, 2022
@suzuki-shunsuke suzuki-shunsuke mentioned this pull request Dec 31, 2022
Merged
@suzuki-shunsuke
Copy link
Member

suzuki-shunsuke commented Dec 31, 2022 •
edited

Supported old version by enabling rosetta2.
463d101

@suzuki-shunsuke suzuki-shunsuke merged commit 31ee0a2 into aquaproj:main Dec 31, 2022
@suzuki-shunsuke
Copy link
Member

Released. https://github.com/aquaproj/aqua-registry/releases/tag/v3.114.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v3.114.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ryodocx @suzuki-shunsuke