Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add mmalcek/bafi #9734

Merged
merged 1 commit into from Feb 9, 2023

Conversation

CrystalMethod
Copy link
Contributor

mmalcek/bafi: Universal JSON, BSON, YAML, CSV, XML converter with templates

$ aqua g -i mmalcek/bafi

How to confirm if this package works well

Reviewers aren't necessarily familiar with this package, so please describe how to confirm if this package works well.
Please confirm if this package works well yourself as much as possible.

Command and output

$ bafi --help
Usage of bafi:
  -d string
        input delimiter: CSV only, default is comma -d ';' or -d 0x09
  -f string
        input format: json, bson, yaml, csv, xml(default)
  -i string
        input file
         -if not defined read from stdin (pipe mode)
         -if prefixed with "?" app will expect yaml file with multiple files description.
  -o string
        output file,
         -if not defined write to stdout (pipe mode)
  -t string
        template, file or inline.
         -Inline template should start with ? e.g. -t "?{{.MyValue}}"
  -v    show version (Project page: https://github.com/mmalcek/bafi)

[mmalcek/bafi](https://github.com/mmalcek/bafi): Universal JSON, BSON, YAML, CSV, XML converter with templates

```console
$ aqua g -i mmalcek/bafi
```

## How to confirm if this package works well

Reviewers aren't necessarily familiar with this package, so please describe how to confirm if this package works well.
Please confirm if this package works well yourself as much as possible.

Command and output

```console
$
```

If files such as configuration file are needed, please share them.

```
```

Reference

-
@CrystalMethod
Copy link
Contributor Author

Strange enough: checksum validation doesnt work for me on macos. Aqua tries to verify sha256<->md5

INFO[0000] download and unarchive the package            aqua_version=1.33.0 env=darwin/amd64 package_name=mmalcek/bafi package_version=v1.0.17 program=aqua registry=standard
ERRO[0006] install the package                           actual_checksum=24AAFB95F8D788B7614B64CDEFBF3738A3E9054ABA58B0534BC9CB7D0115E2BA aqua_version=1.33.0 env=darwin/amd64 error="checksum is invalid" expected_checksum=774F0E027307D87DBC7570CAA8154774 package_name=mmalcek/bafi package_version=v1.0.17 program=aqua registry=standard
FATA[0006] aqua failed                                   aqua_version=1.33.0 env=darwin/amd64 error="it failed to install some packages" program=aqua

@suzuki-shunsuke suzuki-shunsuke added the enhancement New feature or request label Feb 8, 2023
@suzuki-shunsuke
Copy link
Member

Thank you always!

@suzuki-shunsuke
Copy link
Member

Strange enough: checksum validation doesnt work for me on macos. Aqua tries to verify sha256<->md5

INFO[0000] download and unarchive the package            aqua_version=1.33.0 env=darwin/amd64 package_name=mmalcek/bafi package_version=v1.0.17 program=aqua registry=standard
ERRO[0006] install the package                           actual_checksum=24AAFB95F8D788B7614B64CDEFBF3738A3E9054ABA58B0534BC9CB7D0115E2BA aqua_version=1.33.0 env=darwin/amd64 error="checksum is invalid" expected_checksum=774F0E027307D87DBC7570CAA8154774 package_name=mmalcek/bafi package_version=v1.0.17 program=aqua registry=standard
FATA[0006] aqua failed                                   aqua_version=1.33.0 env=darwin/amd64 error="it failed to install some packages" program=aqua

It looks strange. 🤔

Could you check aqua-checksums.json?

In my laptop

    {
      "id": "github_release/github.com/mmalcek/bafi/v1.0.17/bafi_v1.0.17_darwin_amd64.tgz",
      "checksum": "774F0E027307D87DBC7570CAA8154774",
      "algorithm": "md5"
    }

It seems your aqua-checksusms.json's algorithm is wrong as the following.

    {
      "id": "github_release/github.com/mmalcek/bafi/v1.0.17/bafi_v1.0.17_darwin_amd64.tgz",
      "checksum": "774F0E027307D87DBC7570CAA8154774",
      "algorithm": "sha256"
    }

I'm not sure why the algorithm is wrong.

@suzuki-shunsuke suzuki-shunsuke added this to the v3.128.0 milestone Feb 8, 2023
@CrystalMethod
Copy link
Contributor Author

The command

aqua-registry scaffold mmalcek/bafi

initially generated pkgs/mmalcek/bafi/registry.yaml with algorithm sha256 that I manually fixed to md5. But aqua-checksums.json was not updated. So I fixed aqua-checksums.json as well and that solved my problem. Thanks for the hint.

@suzuki-shunsuke suzuki-shunsuke merged commit 2472ca4 into aquaproj:main Feb 9, 2023
@suzuki-shunsuke
Copy link
Member

@CrystalMethod CrystalMethod deleted the feat/mmalcek/bafi branch February 11, 2023 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants