Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github-tags datasource is enabled unexpectedly #211

Closed
suzuki-shunsuke opened this issue Aug 12, 2022 · 3 comments
Closed

github-tags datasource is enabled unexpectedly #211

suzuki-shunsuke opened this issue Aug 12, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@suzuki-shunsuke
Copy link
Member

suzuki-shunsuke commented Aug 12, 2022

e.g.

https://github.com/aquaproj/aqua-registry/pulls

image

@suzuki-shunsuke suzuki-shunsuke added the bug Something isn't working label Aug 12, 2022
@suzuki-shunsuke suzuki-shunsuke changed the title github-tags datasource isn't disabled github-tags datasource is enabled unexpectedly Aug 12, 2022
@suzuki-shunsuke
Copy link
Member Author

suzuki-shunsuke commented Aug 12, 2022

Oh, I got it.
This is because the argument of matchPath isn't a regular expression but a glob.
The regexManager's fileMatch matches, but packageRule's matchPath doesn't match.

{
"fileMatch": ["{{arg0}}"],
"matchStrings": [
" +['\"]?(version|ref)['\"]? *: +['\"]?(?<currentValue>[^'\" \\n]+?)['\"]? +# renovate: depName=(?<depName>[^\\n]+)",
" +['\"]?name['\"]? *: +['\"]?(?<depName>[^'\" .@/\\n]+/[^'\" @/\\n]+)(/[^'\" /@\\n]+)*@(?<currentValue>[^'\" \\n]+)['\"]?"
],
"datasourceTemplate": "github-tags"
},

{
"matchPaths": [
"{{arg0}}"
],
"matchDatasources": ["github-tags"],
"enabled": false
},

https://github.com/aquaproj/aqua-registry/blob/4dd475b49c7b70341710fba4b22dcfba5fe35bca/renovate.json5#L8

"github>aquaproj/aqua-renovate-config:file#1.2.3(pkgs/.*/pkg\\.yaml)",

@suzuki-shunsuke
Copy link
Member Author

suzuki-shunsuke commented Aug 12, 2022

default.json has nothing to do with this bug.
This bug is reproduced only when a regular expression is used in file.json's argument.

@suzuki-shunsuke
Copy link
Member Author

This bug is caused by #207

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant