Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

registry: Add private field to prevent wasted HTTP requests #1466

Closed
suzuki-shunsuke opened this issue Dec 25, 2022 · 0 comments · Fixed by #1486
Closed

registry: Add private field to prevent wasted HTTP requests #1466

suzuki-shunsuke opened this issue Dec 25, 2022 · 0 comments · Fixed by #1486
Labels
enhancement New feature or request
Milestone

Comments

@suzuki-shunsuke
Copy link
Member

Feature Overview

Add a boolean field private and if the field is true, aqua doesn't call HTTP requests to download assets and directly calls GitHub API.

Why is the feature needed?

Please explain the problem you want to solve.

This change prevents aqua from calling HTTP requests to download assets.
aqua can't download assets without GitHub Access Token, so the request is wasteful.

Does the feature include Breaking Changes?

No.

Example Code

command and configuration

$ 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant