Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aqua gr generates wrong code #2693

Open
suzuki-shunsuke opened this issue Feb 16, 2024 · 0 comments
Open

aqua gr generates wrong code #2693

suzuki-shunsuke opened this issue Feb 16, 2024 · 0 comments
Labels
bug Something isn't working command:generate-registry

Comments

@suzuki-shunsuke
Copy link
Member

aqua info

$ aqua info
{
  "version": "2.23.1",
  "commit_hash": "65fb59915fced5e16413e59cd17b3f0a1b42b972",
  "os": "darwin",
  "arch": "arm64",
  "pwd": "/Users/(USER)/repos/src/github.com/aquaproj/aqua-registry",
  "root_dir": "/Users/(USER)/.local/share/aquaproj-aqua",
  "env": {
    "AQUA_GLOBAL_CONFIG": "/Users/(USER)/repos/src/github.com/suzuki-shunsuke/dotfiles/aqua.yaml:/Users/(USER)/repos/src/github.com/aquaproj/aqua-registry/aqua-all.yaml",
    "AQUA_PROGRESS_BAR": "true"
  },
  "config_files": [
    {
      "path": "/Users/(USER)/repos/src/github.com/aquaproj/aqua-registry/aqua.yaml"
    }
  ]
}

Overview

aqua gr martinvonz/jj generates the wrong code.

https://github.com/martinvonz/jj/releases/tag/v0.3.1 : There is no asset.

How to reproduce

Executed command and output

$ aqua gr martinvonz/jj 
packages:
  - type: github_release
    repo_owner: martinvonz
    repo_name: jj
    description: A Git-compatible VCS that is both simple and powerful
    version_constraint: "false"
    version_overrides:
      - version_constraint: semver("<= 0.3.0")
        asset: jj_{{.Version}}_{{.Arch}}-{{.OS}}.{{.Format}}
        format: zip
        windows_arm_emulation: true
        replacements:
          amd64: x86_64
          linux: unknown-linux-musl
          windows: pc-windows-gnu
        checksum:
          type: github_release
          asset: jj_{{.Version}}_{{.Arch}}-{{.OS}}.zip.sha256sum
          algorithm: sha256
        overrides:
          - goos: linux
            format: tar.gz
        supported_envs:
          - linux/amd64
          - windows/amd64
      - version_constraint: Version == "v0.3.1"
        asset: jj_{{.Version}}_{{.Arch}}-{{.OS}}.{{.Format}}
        format: zip
        windows_arm_emulation: true
        replacements:
          amd64: x86_64
          windows: pc-windows-gnu
        supported_envs:
          - windows/amd64
      - version_constraint: semver("<= 0.4.0")
        asset: jj-{{.Version}}-{{.Arch}}-{{.OS}}.{{.Format}}
        format: tar.gz
        rosetta2: true
        windows_arm_emulation: true
        replacements:
          amd64: x86_64
          darwin: apple-darwin
          linux: unknown-linux-musl
          windows: pc-windows-msvc
        overrides:
          - goos: windows
            format: zip
        supported_envs:
          - darwin
          - windows
          - amd64
      - version_constraint: Version == "v0.5.0"
        no_asset: true
      - version_constraint: semver("<= 0.13.0")
        asset: jj-{{.Version}}-{{.Arch}}-{{.OS}}.{{.Format}}
        format: tar.gz
        rosetta2: true
        windows_arm_emulation: true
        replacements:
          amd64: x86_64
          darwin: apple-darwin
          linux: unknown-linux-musl
          windows: pc-windows-msvc
        overrides:
          - goos: windows
            format: zip
        supported_envs:
          - darwin
          - windows
          - amd64
      - version_constraint: "true"
        asset: jj-{{.Version}}-{{.Arch}}-{{.OS}}.{{.Format}}
        format: tar.gz
        windows_arm_emulation: true
        replacements:
          amd64: x86_64
          darwin: apple-darwin
          linux: unknown-linux-musl
          windows: pc-windows-msvc
        overrides:
          - goos: darwin
            replacements:
              arm64: aarch64
          - goos: windows
            format: zip
        supported_envs:
          - darwin
          - windows
          - amd64

Debug output

No response

Expected behaviour

v0.3.1 should be no_asset.

      - version_constraint: Version == "v0.3.1"
        no_asset: true

Actual behaviour

aqua gr generates the following setting.

      - version_constraint: Version == "v0.3.1"
        asset: jj_{{.Version}}_{{.Arch}}-{{.OS}}.{{.Format}}
        format: zip
        windows_arm_emulation: true
        replacements:
          amd64: x86_64
          windows: pc-windows-gnu
        supported_envs:
          - windows/amd64

Note

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working command:generate-registry
Projects
Status: Todo
Development

No branches or pull requests

1 participant