Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include archived repositories in the list #187

Open
suzuki-shunsuke opened this issue Sep 30, 2023 · 2 comments
Open

Include archived repositories in the list #187

suzuki-shunsuke opened this issue Sep 30, 2023 · 2 comments
Labels
bug Something isn't working hacktoberfest

Comments

@suzuki-shunsuke
Copy link
Member

suzuki-shunsuke commented Sep 30, 2023

The list doesn't include archived repositories now.

https://github.com/aquaproj/user-list/blob/ba6ed2a527d5b16dcfb6967abf1534cdbf354267/README.md#how-is-the-list-generated

query := "aquaproj/aqua-registry"
excludedOwners := map[string]struct{}{}
resultMap, err := gh.SearchRepos(ctx, logger, query, excludedOwners)

result, _, err := gh.search.Code(ctx, query, opts)

https://docs.github.com/en/rest/search/search?apiVersion=2022-11-28#search-code

We'd like to include archived repositories too.

@suzuki-shunsuke suzuki-shunsuke added bug Something isn't working hacktoberfest labels Sep 30, 2023
@aybeedee
Copy link

aybeedee commented Oct 1, 2023

Hi @suzuki-shunsuke, I'd like to work on this. Just for pointing me in the right direction, could you let me know if this will be possible by making adjustments to the same REST endpoint (Search Code) currently being used? Or will I have to dig deeper for a solution.

@suzuki-shunsuke
Copy link
Member Author

suzuki-shunsuke commented Oct 1, 2023

Hi, thank you for your contribution!
IIRC, the search code query doesn't support a parameter like archived unfortunately.
So I guess we need to dig deeper for a solution.

Sourcegraph supports the parameter archived, but GitHub Search Code doesn't.
We want the same parameter to GitHub Search Code!

GitHub Search for Repositories supports the parameter archived, but GitHub Search Code doesn't.

https://docs.github.com/en/search-github/searching-on-github/searching-for-repositories#search-based-on-whether-a-repository-is-archived

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working hacktoberfest
Projects
None yet
Development

No branches or pull requests

2 participants