Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(secret): added support of Docker registry credentials #5720

Merged
merged 5 commits into from
Dec 6, 2023
Merged

feat(secret): added support of Docker registry credentials #5720

merged 5 commits into from
Dec 6, 2023

Conversation

sourav977
Copy link
Contributor

@sourav977 sourav977 commented Dec 4, 2023 •
edited by DmitriyLewen

Issue: #5669

Description

added support of Docker registry credentials

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@CLAassistant
Copy link

CLAassistant commented Dec 4, 2023 •
edited

CLA assistant check
All committers have signed the CLA.

@sourav977 sourav977 changed the title added support of Docker registry credentials feat(docker): added support of Docker registry credentials Dec 4, 2023
@sourav977 sourav977 changed the title feat(docker): added support of Docker registry credentials feat(secret): added support of Docker registry credentials Dec 4, 2023
@sourav977 sourav977 mentioned this pull request Dec 4, 2023
Closed
DmitriyLewen
DmitriyLewen reviewed Dec 5, 2023
View reviewed changes
Copy link
Contributor

@DmitriyLewen DmitriyLewen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @sourav977
Thanks for your work!

Left 2 comments. Take a look, please.

pkg/fanal/secret/builtin-rules.go Show resolved Hide resolved
pkg/fanal/secret/builtin-rules.go Outdated Show resolved Hide resolved
@sourav977
Copy link
Contributor Author

@DmitriyLewen
I worked on your review comments, please verify.

DmitriyLewen
DmitriyLewen reviewed Dec 5, 2023
View reviewed changes
Copy link
Contributor

@DmitriyLewen DmitriyLewen left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sourav977
Hm...
Looks like I forgot to save second comment about secret group, or GitHub deleted it.

Anyway, could you take a look at 1 more comment please?

pkg/fanal/secret/builtin-rules.go Outdated Show resolved Hide resolved
DmitriyLewen
DmitriyLewen approved these changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@DmitriyLewen DmitriyLewen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work @sourav977

@knqyf263 i approved this PR. Take a look, when you have time, please.

@knqyf263 knqyf263 added this pull request to the merge queue Dec 6, 2023
Merged via the queue into aquasecurity:main with commit 108a5b0 Dec 6, 2023
12 checks passed
@sourav977 sourav977 deleted the issue_5669 branch December 6, 2023 08:17
@aqua-bot aqua-bot mentioned this pull request May 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DmitriyLewen DmitriyLewen DmitriyLewen approved these changes

@knqyf263 knqyf263 Awaiting requested review from knqyf263 knqyf263 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(secret): add support of Docker registry credentials
4 participants
@sourav977 @CLAassistant @DmitriyLewen @knqyf263