Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(report): use OS information for OS packages purl in github template #5783

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

DmitriyLewen
Copy link
Contributor

@DmitriyLewen DmitriyLewen commented Dec 13, 2023

Description

OS package purl should contains OS name and distro field
e.g. for deb - https://github.com/package-url/purl-spec/blob/master/PURL-TYPES.rst#deb

before: pkg:apk/alpine-baselayout@3.1.2-r0
after: pkg:apk/alpine/alpine-baselayout@3.1.2-r0?arch=x86_64\u0026distro=3.10.2

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@knqyf263
Copy link
Collaborator

@knqyf263
Copy link
Collaborator

There is no default package repository: this should be implied either from the distro qualifiers key or using a repository base url as repository_url qualifiers key.

Oh, there is

@knqyf263 knqyf263 added this pull request to the merge queue Dec 13, 2023
Merged via the queue into aquasecurity:main with commit 6cc00c2 Dec 13, 2023
13 checks passed
@DmitriyLewen DmitriyLewen deleted the fix/gsbom-purl-os-pkgs branch December 13, 2023 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants