Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert(report): don't escape new line characters for sarif format #5897

Merged
merged 1 commit into from Jan 9, 2024

Conversation

DmitriyLewen
Copy link
Contributor

@DmitriyLewen DmitriyLewen commented Jan 9, 2024

Description

We added escaping for sarif report.
But after #5804, recheck docs and discuss this with GitHub team, we understand that we don't need to escape newlines for text and markdown properties.

Related PRs

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@DmitriyLewen DmitriyLewen self-assigned this Jan 9, 2024
@DmitriyLewen DmitriyLewen marked this pull request as ready for review January 9, 2024 10:34
@knqyf263 knqyf263 added this pull request to the merge queue Jan 9, 2024
Merged via the queue into aquasecurity:main with commit 56c4e24 Jan 9, 2024
14 checks passed
@DmitriyLewen DmitriyLewen deleted the revert/sarif-escaping branch January 10, 2024 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants