Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump Go to 1.22 #6075

Merged
merged 3 commits into from
Apr 8, 2024
Merged

chore: bump Go to 1.22 #6075

merged 3 commits into from
Apr 8, 2024

Conversation

knqyf263
Copy link
Collaborator

@knqyf263 knqyf263 commented Feb 7, 2024

Description

Go now has forward compatibility. A project that needs Go 1.22 can be compiled with Go 1.21 as Go transparently downloads Go 1.22.

$ go version
go version go1.21.6 darwin/arm64
$ go mod tidy
go: downloading go1.22.0 (darwin/arm64)

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

Signed-off-by: knqyf263 <knqyf263@gmail.com>
@knqyf263 knqyf263 self-assigned this Feb 7, 2024
@knqyf263
Copy link
Collaborator Author

knqyf263 commented Feb 7, 2024

Waiting for TinyGo v0.31.0.
https://github.com/tinygo-org/tinygo/milestone/17

@simar7
Copy link
Member

simar7 commented Feb 29, 2024

Waiting for TinyGo v0.31.0.
https://github.com/tinygo-org/tinygo/milestone/17

New version was released so I updated it here

@simar7
Copy link
Member

simar7 commented Feb 29, 2024

Strangely enough the build still fails, although locally it seems to be fine for me.

@nikpivkin
Copy link
Contributor

For some reason net.Buffers has been removed from tinygo. I created an issue.

@rogercoll
Copy link

Related to this issue, Trivy modules cannot be compiled with latest TinyGo(0.31.1) version:

$ tinygo build -o spring4shell.wasm -scheduler=none -target=wasi --no-debug spring4shell.go
# github.com/mailru/easyjson/buffer
../../../.go/pkg/mod/github.com/mailru/easyjson@v0.7.7/buffer/pool.go:171:14: undefined: net.Buffers

@knqyf263
Copy link
Collaborator Author

knqyf263 commented Mar 4, 2024

I removed the easyjson dependency in #6240. After it gets merged, it will be fixed.

@evacchi
Copy link
Contributor

evacchi commented Mar 9, 2024

fyi you might not need to remove the easyjson dep after all tinygo-org/net#22 :)

@knqyf263
Copy link
Collaborator Author

fyi you might not need to remove the easyjson dep after all tinygo-org/net#22 :)

Thanks for sharing! But I wanted to remove the dependency anyway. It's a good opportunity🙃

@knqyf263 knqyf263 marked this pull request as ready for review April 8, 2024 08:18
@knqyf263 knqyf263 added this pull request to the merge queue Apr 8, 2024
Merged via the queue into aquasecurity:main with commit 06b4473 Apr 8, 2024
12 checks passed
@knqyf263 knqyf263 deleted the go122 branch April 8, 2024 11:26
fl0pp5 pushed a commit to altlinux/trivy that referenced this pull request May 6, 2024
Signed-off-by: knqyf263 <knqyf263@gmail.com>
Co-authored-by: Simar <simar@linux.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants