refactor(terraform): sync funcs with Terraform #6415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simar7
reviewed
Apr 2, 2024
Comment on lines
15
to
14
| // CidrHostFunc constructs a function that calculates a full host IP address | ||
| // CidrHostFunc contructs a function that calculates a full host IP address |
simar7
reviewed
Apr 2, 2024
Comment on lines
124
to
127
| return cty.UnknownVal(cty.String), fmt.Errorf("error occurred generating password %s", err.Error()) | ||
| return cty.UnknownVal(cty.String), fmt.Errorf("error occured generating password %s", err.Error()) |
simar7
reviewed
Apr 2, 2024
Comment on lines
169
to
173
| errStr = strings.ReplaceAll(e.Error(), "asn1: structure error", "invalid ASN1 data in the given private key") | ||
| errStr = strings.ReplaceAll(e.Error(), "asn1: struture error", "invalid ASN1 data in the given private key") |
simar7
reviewed
Apr 2, 2024
Comment on lines
209
to
213
| // Sha512Func constructs a function that computes the SHA512 hash of a given string | ||
| // Sha512Func contructs a function that computes the SHA512 hash of a given string |
simar7
approved these changes
Apr 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated existing functions, added new ones and removed unused public methods.
Related issues
Remove this section if you don't have related PRs.
Checklist