Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(misconf): avoid panic if the scheme is not valid #6496

Merged
merged 1 commit into from
Apr 15, 2024
Merged

fix(misconf): avoid panic if the scheme is not valid #6496

merged 1 commit into from
Apr 15, 2024

Conversation

nikpivkin
Copy link
Contributor

@nikpivkin nikpivkin commented Apr 15, 2024 •
edited

Description

A non-valid REGO schema passed by the user can cause panic.

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@nikpivkin nikpivkin marked this pull request as ready for review April 15, 2024 13:26
@nikpivkin nikpivkin requested a review from simar7 as a code owner April 15, 2024 13:26
simar7
simar7 approved these changes Apr 15, 2024
View reviewed changes
Copy link
Member

@simar7 simar7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@simar7 simar7 added this pull request to the merge queue Apr 15, 2024
Merged via the queue into main with commit 4337068 Apr 15, 2024
16 checks passed
@simar7 simar7 deleted the rego-schema branch April 15, 2024 20:40
fl0pp5 pushed a commit to altlinux/trivy that referenced this pull request May 6, 2024
@nikpivkin @fl0pp5
fix(misconf): avoid panic if the scheme is not valid (aquasecurity#6496)
fb61524
@aqua-bot aqua-bot mentioned this pull request May 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simar7 simar7 simar7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nikpivkin @simar7