Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(gobinaries): empty Package for gobinaries without main information #6709

Closed
DmitriyLewen opened this issue May 16, 2024 Discussed in #6693 · 0 comments · Fixed by #6710
Closed

bug(gobinaries): empty Package for gobinaries without main information #6709

DmitriyLewen opened this issue May 16, 2024 Discussed in #6693 · 0 comments · Fixed by #6710
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@DmitriyLewen
Copy link
Contributor

Description

There are times when gobinaries don't contain Main information.
e.g.:

➜ go version -m go
go: go1.22.2
	path	cmd/go
	build	-buildmode=exe
	build	-compiler=gc
	build	-gcflags=cmd/...=-dwarf=false
	build	-trimpath=true
	build	DefaultGODEBUG=httplaxcontentlength=1,httpmuxgo121=1,panicnil=1,tls10server=1,tlsrsakex=1,tlsunsafeekm=1
	build	CGO_ENABLED=0
	build	GOARCH=arm64
	build	GOOS=darwin
➜ go version -m gofmt
gofmt: go1.22.2
	path	cmd/gofmt
	build	-buildmode=exe
	build	-compiler=gc
	build	-gcflags=cmd/...=-dwarf=false
	build	-trimpath=true
	build	DefaultGODEBUG=httplaxcontentlength=1,httpmuxgo121=1,panicnil=1,tls10server=1,tlsrsakex=1,tlsunsafeekm=1
	build	CGO_ENABLED=0
	build	GOARCH=arm64
	build	GOOS=darwin

We don't need to add empty root Packages for these binaries.

Discussed in #6693

@DmitriyLewen DmitriyLewen added the kind/bug Categorizes issue or PR as related to a bug. label May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant