Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure all exceptions and messages have been sent to Sentry before returning #8

Open
arabold opened this issue Jul 6, 2017 · 3 comments

Comments

@arabold
Copy link
Owner

arabold commented Jul 6, 2017

See getsentry/raven-node#338 for more details

Without this we risk to miss errors and messages as they are never sent out.

@bericp1
Copy link

bericp1 commented Sep 27, 2018

Hey @arabold -- have you seen getsentry/sentry-javascript#1380

The new unified SDK seems to have remedied this. Not sure if it's crossed your radar or planned for development or not.

The new node SDK is @sentry/node and they explicitly address draining here in the docs.

I realize this means rewriting arabold/serverless-sentry-lib to use @sentry/node but figured I'd drop some links here for the sake of drawing your attention to it.

@arabold
Copy link
Owner Author

arabold commented Sep 27, 2018

Thanks. Indeed I missed that update.

@demetrio812
Copy link

Hello, is this the reason why I don't get any messages logged (using AWS Lambda)? Is there a workaround? Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants