Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README to point to react-app-rewired full installation #302

Open
vaughnkoch opened this issue Jun 8, 2021 · 0 comments
Open

Update README to point to react-app-rewired full installation #302

vaughnkoch opened this issue Jun 8, 2021 · 0 comments

Comments

@vaughnkoch
Copy link

First of all, thanks for this package!

The current README tells you to install customize-cra and react-app-rewired with this command:

yarn add customize-cra react-app-rewired --dev

Unfortunately, the readme doesn't mention that you have to update your package.json to use react-app-rewired scripts. I spent several hours trying to debug why my webpack aliases weren't working, and it turned out that my app wasn't even using config-overrides.js. My suggestion would be to tell people to install react-app-rewired by following the install instructions for that package, instead of running that single installation line.

Also, it might help to suggest putting a log line in config-overrides.js just to show the user that it's getting executed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant