Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradient incorrect on light terminal themes #149

Open
cspotcode opened this issue Sep 14, 2023 · 3 comments
Open

Gradient incorrect on light terminal themes #149

cspotcode opened this issue Sep 14, 2023 · 3 comments

Comments

@cspotcode
Copy link

There's not really a fix for this other than to avoid gradients. On light terminal themes, the gradient should fade from black to white, not white to black. It ends up appearing like this:

image
@arcanis
Copy link
Owner

arcanis commented Sep 19, 2023

Since absolutely every reasonable person uses a dark terminal theme it should be fine

More seriously, the visual glitch is fairly minor, so I'd prefer to avoid removing gradients just for that - I guess there isn't an environment variable describing whether the terminal is light / dark ? 😅

@arcanis
Copy link
Owner

arcanis commented Sep 19, 2023

Interestingly, on my terminal (iTerm2) there's still a little visual glitch mid-way:

Screenshot 2023-09-19 at 11 22 08

@romdej
Copy link

romdej commented Apr 25, 2024

There's another issue concerning non-black-and-white terminals: the gradient color doesn't consistently match the color of the header line.

Here's how it renders in Jetbrains IDE terminals (default theme):
image

Here's how it renders in Jetbrains IDE terminals (colored theme);
image

And this is what it could render on colored terminal without the gradient:
image

While this might not be sufficient for removing the gradients, it's good to known that this issue also exists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants