Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clipanion 2 Yup Validation Context #61

Open
elmpp opened this issue Dec 19, 2020 · 2 comments
Open

Clipanion 2 Yup Validation Context #61

elmpp opened this issue Dec 19, 2020 · 2 comments

Comments

@elmpp
Copy link

elmpp commented Dec 19, 2020

It'd be nice if the Clipanion context could be supplied as a Yup validate context so that we could have additional abilities in .when conditions. My use case is to validate based on the user's cwd

Of course this is Clipanion 2. Would you accept a PR (with tests haha)?

@elmpp elmpp changed the title Clipanion 2 Feature Clipanion 2 Yup Validation Context Dec 19, 2020
@arcanis
Copy link
Owner

arcanis commented Dec 19, 2020

Actually we don't use Yup anymore in Clipanion 2 (still in dev)! The integration is now with Typanion, a sibling library of mine 🙂

That said, I'm not sure how it would work with passing a context, since this concept doesn't really exist in Typanion 🤔

@elmpp
Copy link
Author

elmpp commented Dec 19, 2020

Feels a pretty natural fit what with Clipanion's Context already typed and available. I'll leave this open as a reminder perhaps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants