Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate button not working #6

Open
dinoypp opened this issue Dec 2, 2019 · 3 comments
Open

Generate button not working #6

dinoypp opened this issue Dec 2, 2019 · 3 comments

Comments

@dinoypp
Copy link

dinoypp commented Dec 2, 2019

Was working a few weeks ago. Today, it doesn't generate any links! I have tried different browsers and clearing my cache.

@arcanis
Copy link
Owner

arcanis commented Dec 2, 2019

I've just tried and it seems to work (I tried with "Foo" on one line and "Bar" on another) - can you share the content you paste in the box (or something that would allow be to reproduce the problem, generally speaking)?

@bikerusl
Copy link

bikerusl commented Dec 5, 2019

Hi, I was also having the button doing nothing on Firefox. I didn't bother resetting my cache.

I tried
Santa
Elf
Krampus
Ms. Klaus
Elvis
Rudolf
Santa !Ms. Klaus
Santa =Krampus

...which didn't work.

Then I did a list with no other rules that did work.

Then I did:
Santa
Elf
Krampus
Ms. Klaus
Elvis
Rudolf
Rudolf !Elvis

which didn't work. but then I tried:
Santa
Elf
Krampus
Ms. Klaus
Elvis
Rudolf !Elvis

Which did work.

So I'm assuming the syntax is each name can only be given once at the start of a line? But can be used multiple times in various rules?

Could you maybe make a few example case templates for us to clarify syntax? I always find an example easier than a described explanation. And having a few cases to look at makes it easier to see.

Thanks for making this :-D So many times we've done a commercial one and it spams you for years afterwards. This is much better.

@jmelett
Copy link

jmelett commented Dec 14, 2021

I think the issue is related to the "matching" function. When using following parameters, everything works:

Cat
Elephant
Mouse
Tiger

As soon you add the matching part, the console throws an error

Cat
Elephant
Mouse
Tiger

Tiger =Mouse

SecretSanta.js:13 Uncaught Error: Cannot redefine Tiger at SecretSanta.add (SecretSanta.js:13) at HTMLFormElement.generate ((index):377) SecretSanta.add @ SecretSanta.js:13 generate @ (index):377

Unfortunately I don't know any JS to help, but maybe this helps to narrow it down.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants