New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make SlotMachine class a Stack middleware #16

Open

adamelso opened this issue Jan 27, 2015 · 0 comments

Labels

3.0 enhancement

Member

adamelso commented Jan 27, 2015

At the moment the Symfony request is either injected into the constructor or a new one is created from globals by default. https://github.com/archfizz/slotmachine/blob/master/src/SlotMachine/SlotMachine.php#L66

It would be better to implement HttpKernelInterface and handle the request instead.

This would also make it Stack compliant.

http://stackphp.com/

adamelso added the enhancement label

adamelso added the 3.0 label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment