Skip to content

Commit 1043219

Browse files
committedOct 6, 2021
fix implicit dependencies
1 parent 4c78b1d commit 1043219

File tree

6 files changed

+18
-12
lines changed

6 files changed

+18
-12
lines changed
 

‎.changeset/nasty-teachers-judge.md

+7
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
---
2+
'@graphql-tools/graphql-tag-pluck': patch
3+
'@graphql-tools/load-files': patch
4+
'@graphql-tools/utils': patch
5+
---
6+
7+
fix implicit dependencies

‎.eslintrc.json

+6-4
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,8 @@
3434
"@typescript-eslint/naming-convention": "off",
3535
"@typescript-eslint/interface-name-prefix": "off",
3636
"@typescript-eslint/explicit-module-boundary-types": "off",
37-
"default-param-last": "off"
37+
"default-param-last": "off",
38+
"import/no-extraneous-dependencies": ["error", {"devDependencies": ["**/*.test.ts", "**/*.spec.ts"]}]
3839
},
3940
"env": {
4041
"es6": true,
@@ -43,14 +44,15 @@
4344
"overrides": [
4445
{
4546
"files": [
46-
"**/test/**/*.{ts,js}",
47-
"*.spec.ts"
47+
"**/{test,tests,testing}/**/*.{ts,js}",
48+
"*.{spec,test}.{ts,js}"
4849
],
4950
"env": {
5051
"jest": true
5152
},
5253
"rules": {
53-
"@typescript-eslint/no-unused-vars": "off"
54+
"@typescript-eslint/no-unused-vars": "off",
55+
"import/no-extraneous-dependencies": "off"
5456
}
5557
}
5658
],

‎packages/graphql-tag-pluck/src/index.ts

+2-4
Original file line numberDiff line numberDiff line change
@@ -228,10 +228,9 @@ const MissingVueTemplateCompilerError = new Error(
228228
);
229229

230230
async function pluckVueFileScript(fileData: string) {
231-
// tslint:disable-next-line: no-implicit-dependencies
232231
let vueTemplateCompiler: typeof import('@vue/compiler-sfc');
233232
try {
234-
// tslint:disable-next-line: no-implicit-dependencies
233+
// eslint-disable-next-line import/no-extraneous-dependencies
235234
vueTemplateCompiler = await import('@vue/compiler-sfc');
236235
} catch (e: any) {
237236
throw MissingVueTemplateCompilerError;
@@ -241,11 +240,10 @@ async function pluckVueFileScript(fileData: string) {
241240
}
242241

243242
function pluckVueFileScriptSync(fileData: string) {
244-
// tslint:disable-next-line: no-implicit-dependencies
245243
let vueTemplateCompiler: typeof import('@vue/compiler-sfc');
246244

247245
try {
248-
// tslint:disable-next-line: no-implicit-dependencies
246+
// eslint-disable-next-line import/no-extraneous-dependencies
249247
vueTemplateCompiler = require('@vue/compiler-sfc');
250248
} catch (e: any) {
251249
throw MissingVueTemplateCompilerError;

‎packages/load-files/src/index.ts

+1-2
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,7 @@ import globby, { sync as globbySync, GlobbyOptions } from 'globby';
22
import unixify from 'unixify';
33
import { extname } from 'path';
44
import { statSync, readFileSync, promises as fsPromises } from 'fs';
5-
import { DocumentNode } from '@apollo/client/core';
6-
import { parse } from 'graphql';
5+
import { DocumentNode, parse } from 'graphql';
76

87
const { readFile, stat } = fsPromises;
98

‎packages/utils/src/comments.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { Maybe } from '@graphql-tools/utils';
1+
import { Maybe } from './types';
22
import {
33
StringValueNode,
44
FieldDefinitionNode,

‎packages/utils/src/implementsAbstractType.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { GraphQLType, GraphQLSchema, doTypesOverlap, isCompositeType } from 'graphql';
2-
import { Maybe } from '@graphql-tools/utils';
2+
import { Maybe } from './types';
33

44
export function implementsAbstractType(schema: GraphQLSchema, typeA: Maybe<GraphQLType>, typeB: Maybe<GraphQLType>) {
55
if (typeB == null || typeA == null) {

1 commit comments

Comments
 (1)
Please sign in to comment.