From 294dedda609e366c60d149b194714d54210c4a03 Mon Sep 17 00:00:00 2001 From: peter-subscale <69773350+peter-subscale@users.noreply.github.com> Date: Tue, 27 Oct 2020 11:58:15 +1030 Subject: [PATCH] Fix type error with `arguments` being undefined (#2078) * Fix type error with `arguments` being undefined * Use the Coalesce Nullish operator * add changeset Co-authored-by: Arda TANRIKULU --- .changeset/cool-ads-sin.md | 5 +++++ .changeset/itchy-pillows-trade.md | 5 +++++ packages/delegate/src/transforms/AddArgumentsAsVariables.ts | 2 +- 3 files changed, 11 insertions(+), 1 deletion(-) create mode 100644 .changeset/cool-ads-sin.md create mode 100644 .changeset/itchy-pillows-trade.md diff --git a/.changeset/cool-ads-sin.md b/.changeset/cool-ads-sin.md new file mode 100644 index 00000000000..77bd48c0559 --- /dev/null +++ b/.changeset/cool-ads-sin.md @@ -0,0 +1,5 @@ +--- +'@graphql-tools/delegate': patch +--- + +fix(delegate): Fix type error with `arguments` being undefined diff --git a/.changeset/itchy-pillows-trade.md b/.changeset/itchy-pillows-trade.md new file mode 100644 index 00000000000..256cd928fb5 --- /dev/null +++ b/.changeset/itchy-pillows-trade.md @@ -0,0 +1,5 @@ +--- +'@graphql-tools/url-loader': patch +--- + +fix(url-loader): fix typing mismatch diff --git a/packages/delegate/src/transforms/AddArgumentsAsVariables.ts b/packages/delegate/src/transforms/AddArgumentsAsVariables.ts index d70904f443d..53a576a42a8 100644 --- a/packages/delegate/src/transforms/AddArgumentsAsVariables.ts +++ b/packages/delegate/src/transforms/AddArgumentsAsVariables.ts @@ -83,7 +83,7 @@ function addVariablesToRootField( operation.selectionSet.selections.forEach((selection: SelectionNode) => { if (selection.kind === Kind.FIELD) { - const argumentNodes = selection.arguments; + const argumentNodes = selection.arguments ?? []; const argumentNodeMap: Record = argumentNodes.reduce( (prev, argument) => ({ ...prev,