fix(delegate): WrapConcreteTypes regression (#2174)

WrapConcreteTypes should not process fragments that are not on a root type. addresses #2173
ardatan · Nov 1, 2020 · 856e23f · 856e23f
1 parent b25e16c
commit 856e23f
Show file tree

Hide file tree

Showing 4 changed files with 315 additions and 108 deletions.
diff --git a/.changeset/old-wasps-worry.md b/.changeset/old-wasps-worry.md
@@ -0,0 +1,5 @@
+---
+'@graphql-tools/delegate': patch
+---
+
+fix(delegate): WrapConcreteTypes should not process fragments that are not on a root type (#2173)
diff --git a/packages/delegate/src/transforms/WrapConcreteTypes.ts b/packages/delegate/src/transforms/WrapConcreteTypes.ts
@@ -10,6 +10,7 @@ import {
   visitWithTypeInfo,
   isObjectType,
   FieldNode,
+  FragmentDefinitionNode,
 } from 'graphql';
 
 import { Request } from '@graphql-tools/utils';
@@ -47,10 +48,20 @@ function wrapConcreteTypes(
     return document;
   }
 
+  const queryTypeName = targetSchema.getQueryType()?.name;
+  const mutationTypeName = targetSchema.getMutationType()?.name;
+  const subscriptionTypeName = targetSchema.getSubscriptionType()?.name;
+
   const typeInfo = new TypeInfo(targetSchema);
   const newDocument = visit(
     document,
     visitWithTypeInfo(typeInfo, {
+      [Kind.FRAGMENT_DEFINITION]: (node: FragmentDefinitionNode) => {
+        const typeName = node.typeCondition.name.value;
+        if (typeName !== queryTypeName && typeName !== mutationTypeName && typeName !== subscriptionTypeName) {
+          return false;
+        }
+      },
       [Kind.FIELD]: (node: FieldNode) => {
         if (isAbstractType(getNamedType(typeInfo.getType()))) {
           return {

diff --git a/packages/stitch/tests/fragments.test.ts b/packages/stitch/tests/fragments.test.ts