fix(merge): ignore comments while merging directives #3031

ardatan · Aug 12, 2021 · a5fb77a · a5fb77a · vercel · Aug 12, 2021
1 parent 9ede806
commit a5fb77a
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/.changeset/plenty-jars-exist.md b/.changeset/plenty-jars-exist.md
@@ -0,0 +1,5 @@
+---
+'@graphql-tools/merge': patch
+---
+
+fix(merge): ignore comments while merging directives #3031
diff --git a/packages/merge/src/typedefs-mergers/directives.ts b/packages/merge/src/typedefs-mergers/directives.ts
@@ -83,8 +83,14 @@ export function mergeDirectives(
 }
 
 function validateInputs(node: DirectiveDefinitionNode, existingNode: DirectiveDefinitionNode): void | never {
-  const printedNode = print(node);
-  const printedExistingNode = print(existingNode);
+  const printedNode = print({
+    ...node,
+    description: undefined,
+  });
+  const printedExistingNode = print({
+    ...existingNode,
+    description: undefined,
+  });
   // eslint-disable-next-line
   const leaveInputs = new RegExp('(directive @w*d*)|( on .*$)', 'g');
   const sameArguments = printedNode.replace(leaveInputs, '') === printedExistingNode.replace(leaveInputs, '');