Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove onTypeConflict from public api #1044

Closed
brennantaylor opened this issue Jan 14, 2019 · 4 comments
Closed

Remove onTypeConflict from public api #1044

brennantaylor opened this issue Jan 14, 2019 · 4 comments

Comments

@brennantaylor
Copy link

As noted in this thread #863

The following change removed the usage of the parameter: https://github.com/apollographql/graphql-tools/pull/918/files#diff-bb87a5c1cf8e770e2b377a7e61904637L38

Would be good to remove from the public api so people don't think it actually does anything anymore.

@nether-cat
Copy link

Please bring back onTypeConflict

As also noted in that thread multiple times, there are scenarios in which this feature seemingly cannot be substituted with schema transforms. How could I merge the values of two enum types for example?

@januszhou
Copy link

Agreed, since onTypeConflict has been removed, it will at least less confused.

@brennantaylor
Copy link
Author

@nether-cat You would query the individual schemas and reconcile it before calling mergeSchemas. It is possible with schema transforms.

We were able to replace all our type conflict resolution with our own programmed with schema transforms. It's just not as friendly.

What would have been nice is instead of removing the functionality if they wanted mergeSchemas to be more pure they could have lifted the type conflict stuff to a new function instead.

@yaacovCR
Copy link
Collaborator

Brought back, rolled into #1306

@yaacovCR yaacovCR mentioned this issue Mar 29, 2020
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants