Declaring schema directive on extended type does not populate astNode.directive property

[simon-bigsofa]

Declared a custom @auth directive on OBJECT:
directive @auth on OBJECT

The directive extends SchemaDirectiveVisitor and implements visitObject

When the directive is applied to the original type it works correctly and the type requires authorisation.

type Stream @auth {
  name: String!
}

When the directive is applied to an extended type (and not the original type definition) it is completely ignored.

  extend type Stream @auth {
    uid: String!
  }

When applied to the extended type the astNode.directives property of the Stream type is empty.

I couldn't see anything in the docs or the spec which suggests that OBJECT level directives can not be applied to extended types. Any ideas?

[yaacovCR]

Caused by checking only astNode rather than also all extensionASTNodes at https://github.com/apollographql/graphql-tools/blob/master/src/schemaVisitor.ts#L546

Fixed in graphql-tools-fork v8.9.5

[simon-bigsofa]

That's fantastic @yaacovCR - Indeed that has fixed the issue. Thank you!

[TimSusa]

Why just not taking over graphql-tools-fork fixes to graphql-tools? Really hard for me to understand, just to say its deprecated. Seems to me, like a sad story.

[yaacovCR]

Folded into #1306, fixed by #1307