Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default Apollo Engine endpoint #1560

Merged
merged 1 commit into from May 29, 2020
Merged

Conversation

lsanwick
Copy link
Contributor

Generally, users are not going to provide a custom endpoint for fetching from the Apollo Engine, so make it optional and add a sensible default value.

TODO:

  • If this PR is a new feature, reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass
  • Update CHANGELOG.md with your change. Include a description of your change, link to PR (always) and issue (if applicable). Add your CHANGELOG entry under vNEXT. Do not create a new version number for your change yourself.

Generally, users are not going to provide a custom endpoint for fetching from the Apollo Engine, so make it optional and add a sensible default value.
@ardatan
Copy link
Owner

ardatan commented May 29, 2020

Thank you @lsanwick !

@ardatan ardatan merged commit 68c14f5 into ardatan:master May 29, 2020
@theguild-bot
Copy link
Collaborator

The latest changes of this PR are available as alpha in npm: 6.0.4-alpha-68c14f5.0

Quickly update your package.json by running:

npx match-version @graphql-tools 6.0.4-alpha-68c14f5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants