temporarily make delegationContext optional until next major version #1614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest changes of this PR are available as alpha in npm: Quickly update your package.json by running: |
|
Seems to fix https://github.com/oxilor/graphql-tools-issue-1605 |
|
But addition of specifiedBy directive is causing some -- but not all?? -- graphql v15 versions to fail testing |
|
@yaacovCR Fixed it! |
|
And the plan would be to move the Transform types to delegate in the next major version and make the argument types explicit, correct? Anything better we can do? |
|
@yaacovCR Whatever you think is better option, I am okay with that :) |
|
I think we should push this for now as fixes current bugs, but there might be a better workaround later prior to next major release. |
yaacovCR
added a commit
that referenced
this pull request
Aug 23, 2020
includes also changes to transform method arguments see #1614
yaacovCR
added a commit
that referenced
this pull request
Aug 23, 2020
includes also changes to transform method arguments see #1614
yaacovCR
added a commit
that referenced
this pull request
Aug 23, 2020
includes also changes to transform method arguments see #1614
Merged
yaacovCR
added a commit
that referenced
this pull request
Aug 24, 2020
includes also changes to transform method arguments see #1614
yaacovCR
added a commit
that referenced
this pull request
Aug 25, 2020
includes also changes to transform method arguments see #1614
yaacovCR
added a commit
that referenced
this pull request
Aug 31, 2020
includes also changes to transform method arguments see #1614
yaacovCR
added a commit
that referenced
this pull request
Aug 31, 2020
includes also changes to transform method arguments see #1614
yaacovCR
added a commit
that referenced
this pull request
Sep 2, 2020
includes also changes to transform method arguments see #1614
yaacovCR
added a commit
that referenced
this pull request
Sep 4, 2020
includes also changes to transform method arguments see #1614
yaacovCR
added a commit
that referenced
this pull request
Sep 13, 2020
includes also changes to transform method arguments see #1614
yaacovCR
added a commit
that referenced
this pull request
Sep 21, 2020
includes also changes to transform method arguments see #1614
yaacovCR
added a commit
that referenced
this pull request
Sep 21, 2020
includes also changes to transform method arguments see #1614
yaacovCR
added a commit
that referenced
this pull request
Sep 21, 2020
includes also changes to transform method arguments see #1614
yaacovCR
added a commit
that referenced
this pull request
Sep 21, 2020
includes also changes to transform method arguments see #1614
yaacovCR
added a commit
that referenced
this pull request
Sep 30, 2020
includes also changes to transform method arguments see #1614
yaacovCR
added a commit
that referenced
this pull request
Oct 1, 2020
includes also changes to transform method arguments see #1614
yaacovCR
added a commit
that referenced
this pull request
Oct 6, 2020
includes also changes to transform method arguments see #1614
yaacovCR
added a commit
that referenced
this pull request
Oct 23, 2020
includes also changes to transform method arguments see #1614
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses typing issues in #1605