Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mergeProxiedResults errors aggregation #1621

Conversation

nicolas-cherel
Copy link
Contributor

if sources.length > 0, errors will be in the form [[]], making it non empty, while the source result set is empty. Any code path that checks errors length for result errors will erroneously detect errors.

eg: in handleNull: https://github.com/ardatan/graphql-tools/blob/master/packages/delegate/src/results/handleNull.ts#L6

@ardatan ardatan requested a review from yaacovCR June 9, 2020 15:15
@ardatan ardatan force-pushed the master branch 2 times, most recently from 48510af to 3fd43fb Compare June 9, 2020 15:52
@yaacovCR
Copy link
Collaborator

yaacovCR commented Jun 9, 2020

lgtm, thanks!

@yaacovCR yaacovCR self-assigned this Jun 9, 2020
Copy link
Collaborator

@yaacovCR yaacovCR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ardatan do we care if dependabot added changes?

@yaacovCR yaacovCR removed their assignment Jun 9, 2020
@ardatan ardatan merged commit 188fb3d into ardatan:master Jun 9, 2020
@ardatan
Copy link
Owner

ardatan commented Jun 9, 2020

@yaacovCR I think it is fine.

@theguild-bot
Copy link
Collaborator

The latest changes of this PR are available as alpha in npm: 6.0.10-alpha-188fb3d.0

Quickly update your package.json by running:

npx match-version @graphql-tools 6.0.10-alpha-188fb3d.0

@ardatan ardatan added the bugfix label Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants